Re: [PATCH 1/3] band: return -ENOTSUP when RSSI is too low for rate estimation

[Denis Kenzior <denkenz@gmail.com>]

Hi James,

On 4/15/24 10:11, James Prestwood wrote:
> This was overlooked in a prior patch and causes the rate estimation
> to return -ENETUNREACH if the RSSI is too low to support the
> various capabilities. This return was unhandled and was treated as
> if the IE was invalid which then printed a warning.
> 
> The low RSSI case should just be ignored, similar to if the IE was
> not provided at all. In this case return -ENOTSUP so the caller
> moves on to the next capability set.

Err, why?  Just handle the error code.

> 
> Note: this does result in most of the estimation functions only
>        returning 0 or -ENOTSUP as they do little to no validation
>        on the frame, but rather just test bits. Additional
>        validation could be added in the future which would be
>        handled by this patch.
> ---
>   src/band.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)

Hmm, this set is failing CI for some reason?

Regards,
-Denis