[PATCH v2 1/4] network: handle NULL/hotspot networks when removing secrets

Wireless Daemon for Linux
 help / color / mirror / Atom feed

* [PATCH v2 1/4] network: handle NULL/hotspot networks when removing secrets
@ 2021-08-18 21:50 James Prestwood
  2021-08-18 21:50 ` [PATCH v2 2/4] hwsim: add Rule.remove_all() James Prestwood
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: James Prestwood @ 2021-08-18 21:50 UTC (permalink / raw)
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 1475 bytes --]

The hotspot case can actually result in network being NULL which
ends up crashing when accessing "->secrets". In addition any
secrets on this network were never removed for hotspot networks
since everything happened in network_unset_hotspot.
---
 src/network.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/network.c b/src/network.c
index 79f3bd33..d81a201d 100644
--- a/src/network.c
+++ b/src/network.c
@@ -1823,6 +1823,9 @@ static void network_unset_hotspot(struct network *network, void *user_data)
 		return;
 
 	network_set_info(network, NULL);
+
+	l_queue_destroy(network->secrets, eap_secret_info_free);
+	network->secrets = NULL;
 }
 
 static void emit_known_network_removed(struct station *station, void *user_data)
@@ -1841,6 +1844,9 @@ static void emit_known_network_removed(struct station *station, void *user_data)
 			return;
 
 		network_set_info(network, NULL);
+
+		l_queue_destroy(network->secrets, eap_secret_info_free);
+		network->secrets = NULL;
 	}
 
 	connected_network = station_get_connected_network(station);
@@ -1849,9 +1855,6 @@ static void emit_known_network_removed(struct station *station, void *user_data)
 
 	if (network && was_hidden)
 		station_hide_network(station, network);
-
-	l_queue_destroy(network->secrets, eap_secret_info_free);
-	network->secrets = NULL;
 }
 
 static void network_update_hotspot(struct network *network, void *user_data)
-- 
2.31.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v2 2/4] hwsim: add Rule.remove_all()
  2021-08-18 21:50 [PATCH v2 1/4] network: handle NULL/hotspot networks when removing secrets James Prestwood
@ 2021-08-18 21:50 ` James Prestwood
  2021-08-18 21:50 ` [PATCH v2 3/4] auto-t: fix error handling in testHotspot James Prestwood
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: James Prestwood @ 2021-08-18 21:50 UTC (permalink / raw)
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 706 bytes --]

There are really no cases where a test wants to remove a single
rule. Most loop through and remove rules individually so this
is being added as a convenience.
---
 autotests/util/hwsim.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/autotests/util/hwsim.py b/autotests/util/hwsim.py
index 320e9dfa..4e3b8ec2 100755
--- a/autotests/util/hwsim.py
+++ b/autotests/util/hwsim.py
@@ -202,6 +202,10 @@ class RuleSet(collections.Mapping):
         self._dict[path] = obj
         return obj
 
+    def remove_all(self):
+        for rule in self._dict.values():
+            rule.remove()
+
 class Radio(HwsimDBusAbstract):
     _iface_name = HWSIM_RADIO_INTERFACE
 
-- 
2.31.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v2 3/4] auto-t: fix error handling in testHotspot
  2021-08-18 21:50 [PATCH v2 1/4] network: handle NULL/hotspot networks when removing secrets James Prestwood
  2021-08-18 21:50 ` [PATCH v2 2/4] hwsim: add Rule.remove_all() James Prestwood
@ 2021-08-18 21:50 ` James Prestwood
  2021-08-18 21:50 ` [PATCH v2 4/4] test-runner: fix subtest option James Prestwood
  2021-08-18 21:58 ` [PATCH v2 1/4] network: handle NULL/hotspot networks when removing secrets Denis Kenzior
  3 siblings, 0 replies; 5+ messages in thread
From: James Prestwood @ 2021-08-18 21:50 UTC (permalink / raw)
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 6957 bytes --]

testHotspot suffered from improper cleanup and if a single test failed
all subsequent tests would fail due to IWD still running since IWD()
was never cleaned up.

In addition the PSK agent and hwsim rules are now set onto the cls
object and removed in tearDownClass()
---
 autotests/testHotspot/anqp_delay_test.py  | 38 ++++++++++++++---------
 autotests/testHotspot/autoconnect_test.py |  6 +++-
 autotests/testHotspot/hessid_test.py      |  6 +++-
 autotests/testHotspot/hotspot_test.py     |  6 +++-
 autotests/testHotspot/roaming_test.py     | 14 +++++----
 5 files changed, 46 insertions(+), 24 deletions(-)

diff --git a/autotests/testHotspot/anqp_delay_test.py b/autotests/testHotspot/anqp_delay_test.py
index 04e5a1d7..22a5bdbe 100644
--- a/autotests/testHotspot/anqp_delay_test.py
+++ b/autotests/testHotspot/anqp_delay_test.py
@@ -17,19 +17,9 @@ from time import sleep
 class Test(unittest.TestCase):
 
     def test_connection_success(self):
-        hwsim = Hwsim()
-
-        bss_radio = hwsim.get_radio('rad0')
-        rule0 = hwsim.rules.create()
-        rule0.source = bss_radio.addresses[0]
-        rule0.bidirectional = True
-
-        wd = IWD(True)
-
-        hapd = HostapdCLI(config='ssidHotspot.conf')
-
-        psk_agent = PSKAgent('abc', ('domain\\user', 'testpasswd'))
-        wd.register_psk_agent(psk_agent)
+        wd = self.wd
+        hapd = self.hapd
+        rule0 = self.rule0
 
         devices = wd.list_devices(1)
         device = devices[0]
@@ -82,17 +72,35 @@ class Test(unittest.TestCase):
         condition = 'not obj.connected'
         wd.wait_for_object_condition(ordered_network.network_object, condition)
 
-        wd.unregister_psk_agent(psk_agent)
-
     @classmethod
     def setUpClass(cls):
+        cls.hwsim = Hwsim()
+
+        bss_radio = cls.hwsim.get_radio('rad0')
+        cls.rule0 = cls.hwsim.rules.create()
+        cls.rule0.source = bss_radio.addresses[0]
+        cls.rule0.bidirectional = True
+
+        cls.hapd = HostapdCLI(config='ssidHotspot.conf')
+
         IWD.copy_to_hotspot('example.conf')
         IWD.copy_to_storage('anqp_enabled.conf', storage_dir=IWD_CONFIG_DIR, name='main.conf')
 
+        cls.wd = IWD(True)
+        cls.psk_agent = PSKAgent('abc', ('domain\\user', 'testpasswd'))
+        cls.wd.register_psk_agent(cls.psk_agent)
+
     @classmethod
     def tearDownClass(cls):
         IWD.clear_storage()
+
+        cls.wd.unregister_psk_agent(cls.psk_agent)
+        cls.psk_agent = None
         os.remove('/tmp/main.conf')
 
+        cls.hwsim.rules.remove_all()
+        cls.hwsim = None
+        cls.wd = None
+
 if __name__ == '__main__':
     unittest.main(exit=True)
diff --git a/autotests/testHotspot/autoconnect_test.py b/autotests/testHotspot/autoconnect_test.py
index 777a0670..8b718dc7 100644
--- a/autotests/testHotspot/autoconnect_test.py
+++ b/autotests/testHotspot/autoconnect_test.py
@@ -14,7 +14,7 @@ import testutil
 class Test(unittest.TestCase):
 
     def test_connection_success(self):
-        wd = IWD(True, '/tmp')
+        wd = self.wd
 
         hapd_hotspot = HostapdCLI(config='ssidHotspot.conf')
         hapd_wpa = HostapdCLI(config='ssidWPA2-1.conf')
@@ -111,10 +111,14 @@ class Test(unittest.TestCase):
         IWD.copy_to_storage('ssidWPA2-1.psk')
         IWD.copy_to_storage('anqp_enabled.conf', storage_dir=IWD_CONFIG_DIR, name='main.conf')
 
+        cls.wd = IWD(True)
+
     @classmethod
     def tearDownClass(cls):
         IWD.clear_storage()
         os.remove('/tmp/main.conf')
 
+        cls.wd = None
+
 if __name__ == '__main__':
     unittest.main(exit=True)
diff --git a/autotests/testHotspot/hessid_test.py b/autotests/testHotspot/hessid_test.py
index 88e750de..4a47e5c7 100644
--- a/autotests/testHotspot/hessid_test.py
+++ b/autotests/testHotspot/hessid_test.py
@@ -15,7 +15,7 @@ import testutil
 class Test(unittest.TestCase):
 
     def test_connection_success(self):
-        wd = IWD(True, '/tmp')
+        wd = self.wd
 
         hapd = HostapdCLI(config='ssidHotspot.conf')
 
@@ -52,10 +52,14 @@ class Test(unittest.TestCase):
         IWD.copy_to_hotspot('hessid.conf')
         IWD.copy_to_storage('anqp_disabled.conf', storage_dir=IWD_CONFIG_DIR, name='main.conf')
 
+        cls.wd = IWD(True)
+
     @classmethod
     def tearDownClass(cls):
         IWD.clear_storage()
         os.remove('/tmp/main.conf')
 
+        cls.wd = None
+
 if __name__ == '__main__':
     unittest.main(exit=True)
diff --git a/autotests/testHotspot/hotspot_test.py b/autotests/testHotspot/hotspot_test.py
index f49477dc..054a1a8f 100644
--- a/autotests/testHotspot/hotspot_test.py
+++ b/autotests/testHotspot/hotspot_test.py
@@ -15,7 +15,7 @@ import testutil
 class Test(unittest.TestCase):
 
     def test_connection_success(self):
-        wd = IWD(True, '/tmp')
+        wd = self.wd
 
         hapd = HostapdCLI(config='ssidHotspot.conf')
 
@@ -52,10 +52,14 @@ class Test(unittest.TestCase):
         IWD.copy_to_hotspot('example.conf')
         IWD.copy_to_storage('anqp_enabled.conf', storage_dir=IWD_CONFIG_DIR, name='main.conf')
 
+        cls.wd = IWD(True)
+
     @classmethod
     def tearDownClass(cls):
         IWD.clear_storage()
         os.remove('/tmp/main.conf')
 
+        cls.wd = None
+
 if __name__ == '__main__':
     unittest.main(exit=True)
diff --git a/autotests/testHotspot/roaming_test.py b/autotests/testHotspot/roaming_test.py
index 6cdd6922..1d785700 100644
--- a/autotests/testHotspot/roaming_test.py
+++ b/autotests/testHotspot/roaming_test.py
@@ -15,13 +15,10 @@ import testutil
 class Test(unittest.TestCase):
 
     def test_connection_success(self):
-        wd = IWD(True, '/tmp')
+        wd = self.wd
 
         hapd = HostapdCLI(config='ssidHotspot.conf')
 
-        psk_agent = PSKAgent('abc', ('domain\\user', 'testpasswd'))
-        wd.register_psk_agent(psk_agent)
-
         devices = wd.list_devices(1)
         device = devices[0]
 
@@ -45,17 +42,22 @@ class Test(unittest.TestCase):
         condition = 'not obj.connected'
         wd.wait_for_object_condition(ordered_network.network_object, condition)
 
-        wd.unregister_psk_agent(psk_agent)
-
     @classmethod
     def setUpClass(cls):
         IWD.copy_to_hotspot('roaming.conf')
         IWD.copy_to_storage('anqp_disabled.conf', storage_dir=IWD_CONFIG_DIR, name='main.conf')
 
+        cls.wd = IWD(True)
+        cls.psk_agent = PSKAgent('abc', ('domain\\user', 'testpasswd'))
+        cls.wd.register_psk_agent(cls.psk_agent)
+
     @classmethod
     def tearDownClass(cls):
         IWD.clear_storage()
         os.remove('/tmp/main.conf')
 
+        cls.wd.unregister_psk_agent(cls.psk_agent)
+        cls.wd = None
+
 if __name__ == '__main__':
     unittest.main(exit=True)
-- 
2.31.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH v2 4/4] test-runner: fix subtest option
  2021-08-18 21:50 [PATCH v2 1/4] network: handle NULL/hotspot networks when removing secrets James Prestwood
  2021-08-18 21:50 ` [PATCH v2 2/4] hwsim: add Rule.remove_all() James Prestwood
  2021-08-18 21:50 ` [PATCH v2 3/4] auto-t: fix error handling in testHotspot James Prestwood
@ 2021-08-18 21:50 ` James Prestwood
  2021-08-18 21:58 ` [PATCH v2 1/4] network: handle NULL/hotspot networks when removing secrets Denis Kenzior
  3 siblings, 0 replies; 5+ messages in thread
From: James Prestwood @ 2021-08-18 21:50 UTC (permalink / raw)
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 914 bytes --]

This was not working correctly and would run all subtests when only a single
was requested
---
 tools/test-runner | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/tools/test-runner b/tools/test-runner
index dc65cca4..a19ce1d9 100755
--- a/tools/test-runner
+++ b/tools/test-runner
@@ -1271,16 +1271,18 @@ def pre_test(ctx, test, copied):
 	# Prune down any subtests if needed
 	if ctx.args.sub_tests:
 		ctx.args.sub_tests = ctx.args.sub_tests.split(',')
+
+		to_run = [x.split('.')[0] for x in ctx.args.sub_tests]
 		pruned = []
 
 		for s in subtests:
-			file = s
+			no_ext = s
 			# Handle <file>.<test function> format
 			if '.' in s:
-				file = s.split('.')[0] + '.py'
+				no_ext = s.split('.')[0]
 
-			if file == s:
-				pruned.append(file)
+			if no_ext in to_run:
+				pruned.append(no_ext + '.py')
 
 		subtests = pruned
 
-- 
2.31.1

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH v2 1/4] network: handle NULL/hotspot networks when removing secrets
  2021-08-18 21:50 [PATCH v2 1/4] network: handle NULL/hotspot networks when removing secrets James Prestwood
                   ` (2 preceding siblings ...)
  2021-08-18 21:50 ` [PATCH v2 4/4] test-runner: fix subtest option James Prestwood
@ 2021-08-18 21:58 ` Denis Kenzior
  3 siblings, 0 replies; 5+ messages in thread
From: Denis Kenzior @ 2021-08-18 21:58 UTC (permalink / raw)
  To: iwd

[-- Attachment #1: Type: text/plain, Size: 450 bytes --]

Hi James,

On 8/18/21 4:50 PM, James Prestwood wrote:
> The hotspot case can actually result in network being NULL which
> ends up crashing when accessing "->secrets". In addition any
> secrets on this network were never removed for hotspot networks
> since everything happened in network_unset_hotspot.
> ---
>   src/network.c | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)
> 

All applied, thanks.

Regards,
-Denis

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-08-18 21:58 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-18 21:50 [PATCH v2 1/4] network: handle NULL/hotspot networks when removing secrets James Prestwood
2021-08-18 21:50 ` [PATCH v2 2/4] hwsim: add Rule.remove_all() James Prestwood
2021-08-18 21:50 ` [PATCH v2 3/4] auto-t: fix error handling in testHotspot James Prestwood
2021-08-18 21:50 ` [PATCH v2 4/4] test-runner: fix subtest option James Prestwood
2021-08-18 21:58 ` [PATCH v2 1/4] network: handle NULL/hotspot networks when removing secrets Denis Kenzior

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox