Re: [PATCH 2/2] doc: Add State and Role properties to DPP API

[James Prestwood <prestwoj@gmail.com>]

Hi Jesse,

On Wed, 2022-06-22 at 15:41 -0400, Jesse Lentz wrote:
> Document the State and Role properties of the DeviceProvisioning API.
> ---
>  doc/device-provisioning-api.txt | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/doc/device-provisioning-api.txt b/doc/device-
> provisioning-api.txt
> index 0aba2557..c1d706ec 100644
> --- a/doc/device-provisioning-api.txt
> +++ b/doc/device-provisioning-api.txt
> @@ -56,3 +56,13 @@ Methods              string StartEnrollee()
>                                                 net.connman.iwd.NotCo
> nfigured
>                                                 net.connman.iwd.NotSu
> pported
>                                                 net.connman.iwd.Busy
> +
> +Properties     string State [readonly, optional]
> +
> +                       Reflects the DPP state. Possible values are
> "presence",
> +                       "authenticating", and "configuring".

I think a "stopped" state would also be needed.

> +
> +               string Role [readonly, optional]
> +
> +                       Reflects the DPP role. Possible values are
> "enrollee"
> +                       and "configurator"

I don't think you actually need this one. The role should be implied by
however you started DPP:

StartEnrollee() -> enrollee
StartConfigurator() -> configurator
ConfigureEnrollee() -> configurator

Thanks,
James