Wireless Daemon for Linux
 help / color / mirror / Atom feed
From: "Jesse Lentz" <jesse@twosheds.org>
To: "James Prestwood" <prestwoj@gmail.com>, <iwd@lists.linux.dev>
Subject: Re: [PATCH 2/2] doc: Add State and Role properties to DPP API
Date: Thu, 23 Jun 2022 12:30:37 -0400	[thread overview]
Message-ID: <CKXNNPV68RR1.3ROOO4K1DSKL0@laptop> (raw)
In-Reply-To: <312b2cd5fdede0d7fdd7f45aeda5919e9b22950f.camel@gmail.com>

Hi James,

Thanks for your feedback.

> > +Properties     string State [readonly, optional]
> > +
> > +                       Reflects the DPP state. Possible values are
> > "presence",
> > +                       "authenticating", and "configuring".
>
> I think a "stopped" state would also be needed.

As a user of the API, I can infer that DPP is inactive if "State" is
undefined. A non-optional State property with an explicit "inactive"
value should provide equivalent information; would you prefer the latter
approach?

> > +               string Role [readonly, optional]
> > +
> > +                       Reflects the DPP role. Possible values are
> > "enrollee"
> > +                       and "configurator"
>
> I don't think you actually need this one. The role should be implied by
> however you started DPP:
>
> StartEnrollee() -> enrollee
> StartConfigurator() -> configurator
> ConfigureEnrollee() -> configurator

One use case that I'm trying to address is when a user launches the
front-end app while DPP is already active. There are two ways that I can
think of to handle this:

1) The front-end stops and re-starts DPP if the user requests it. This
only requires iwd to provide State, so that the front-end can see if a
previous invocation must be stopped.

2) iwd provides sufficient information via properties to restore the
previous invocation: State, Role, and URI.

I originally had option 2 in mind, but if DPP invocations are intended
to be transient, then perhaps option 1 would be more appropriate. Let me
know what your thoughts are, and I'll send a revised patch.

Thanks.

Sincerely,
Jesse

  reply	other threads:[~2022-06-23 16:35 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-22 19:41 [PATCH 1/2] dpp: Add State and Role properties to dbus API Jesse Lentz
2022-06-22 19:41 ` [PATCH 2/2] doc: Add State and Role properties to DPP API Jesse Lentz
2022-06-22 20:35   ` James Prestwood
2022-06-23 16:30     ` Jesse Lentz [this message]
2022-06-23 16:47       ` James Prestwood
2022-06-23 17:24         ` Jesse Lentz
2022-06-23 18:00       ` Denis Kenzior
2022-06-23 19:07         ` Jesse Lentz
2022-06-23 19:58           ` Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CKXNNPV68RR1.3ROOO4K1DSKL0@laptop \
    --to=jesse@twosheds.org \
    --cc=iwd@lists.linux.dev \
    --cc=prestwoj@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox