Wireless Daemon for Linux
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: iwd@lists.01.org
Subject: Re: [PATCH] Fix missing `#include "missing.h"`.
Date: Thu, 04 Feb 2021 09:15:53 -0600	[thread overview]
Message-ID: <36c1ae16-ff42-76a1-e46d-d1633deefeb9@gmail.com> (raw)
In-Reply-To: <20210204092937.1726283-1-mc5686@mclink.it>

[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]

Hi Mauro,

Patches against ell should go to ell(a)lists.01.org.  But since this is such a 
trivial one, I'll take care of it.

On 2/4/21 3:29 AM, Mauro Condarelli wrote:
> If explicit_bzero() is not available (e.g.: with uClibc) build fails
> because of:
> 
> ell/cert.c: In function ‘cert_key_from_pkcs8_encrypted_private_key_info’:
> ell/cert.c:665:2: warning: implicit declaration of function ‘explicit_bzero’ [-Wimplicit-function-declaration]
>    665 |  explicit_bzero(decrypted, data_len);
>        |  ^~~~~~~~~~~~~~
> 
> in spite of correct detection:
> 
> checking for explicit_bzero... no
> 
> and:
> 
> ...
> /* Define to 1 if you have the `explicit_bzero' function. */
> /* #undef HAVE_EXPLICIT_BZERO */
> ...
> 
> Fix is adding `#include "missing.h"` as it is done in simila files.
> 
> Signed-off-by: Mauro Condarelli <mc5686@mclink.it>

We don't use the Signed-off-by tags in ell or iwd, so feel free to drop these.

> ---
>   ell/cert.c | 1 +
>   1 file changed, 1 insertion(+)
> 

Applied with a slight tweak to the commit description.

Regards,
-Denis

      reply	other threads:[~2021-02-04 15:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04  9:29 [PATCH] Fix missing `#include "missing.h"` Mauro Condarelli
2021-02-04 15:15 ` Denis Kenzior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36c1ae16-ff42-76a1-e46d-d1633deefeb9@gmail.com \
    --to=denkenz@gmail.com \
    --cc=iwd@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox