[PATCH] Fix missing `#include "missing.h"`.

[PATCH] Fix missing `#include "missing.h"`.

[Mauro Condarelli]

[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]

If explicit_bzero() is not available (e.g.: with uClibc) build fails
because of:

ell/cert.c: In function ‘cert_key_from_pkcs8_encrypted_private_key_info’:
ell/cert.c:665:2: warning: implicit declaration of function ‘explicit_bzero’ [-Wimplicit-function-declaration]
  665 |  explicit_bzero(decrypted, data_len);
      |  ^~~~~~~~~~~~~~

in spite of correct detection:

checking for explicit_bzero... no

and:

...
/* Define to 1 if you have the `explicit_bzero' function. */
/* #undef HAVE_EXPLICIT_BZERO */
...

Fix is adding `#include "missing.h"` as it is done in simila files.

Signed-off-by: Mauro Condarelli <mc5686@mclink.it>
---
 ell/cert.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ell/cert.c b/ell/cert.c
index c26051f..b54c7b1 100644
--- a/ell/cert.c
+++ b/ell/cert.c
@@ -33,6 +33,7 @@
 #include "pem-private.h"
 #include "cert.h"
 #include "cert-private.h"
+#include "missing.h"
 
 #define X509_CERTIFICATE_POS			0
 #define   X509_TBSCERTIFICATE_POS		  0
-- 
2.25.1

Re: [PATCH] Fix missing `#include "missing.h"`.

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 1115 bytes --]

Hi Mauro,

Patches against ell should go to ell(a)lists.01.org.  But since this is such a 
trivial one, I'll take care of it.

On 2/4/21 3:29 AM, Mauro Condarelli wrote:
> If explicit_bzero() is not available (e.g.: with uClibc) build fails
> because of:
> 
> ell/cert.c: In function ‘cert_key_from_pkcs8_encrypted_private_key_info’:
> ell/cert.c:665:2: warning: implicit declaration of function ‘explicit_bzero’ [-Wimplicit-function-declaration]
>    665 |  explicit_bzero(decrypted, data_len);
>        |  ^~~~~~~~~~~~~~
> 
> in spite of correct detection:
> 
> checking for explicit_bzero... no
> 
> and:
> 
> ...
> /* Define to 1 if you have the `explicit_bzero' function. */
> /* #undef HAVE_EXPLICIT_BZERO */
> ...
> 
> Fix is adding `#include "missing.h"` as it is done in simila files.
> 
> Signed-off-by: Mauro Condarelli <mc5686@mclink.it>

We don't use the Signed-off-by tags in ell or iwd, so feel free to drop these.

> ---
>   ell/cert.c | 1 +
>   1 file changed, 1 insertion(+)
> 

Applied with a slight tweak to the commit description.

Regards,
-Denis