Re: [PATCH 6/9] dpp-common: add TX/RX handlers to dpp_sm

[James Prestwood <prestwoj@gmail.com>]

On 4/2/24 8:27 AM, Denis Kenzior wrote:
> Hi James,
>
> On 3/27/24 10:19, James Prestwood wrote:
>> This copies the bulk of the protocol handling from dpp.c into
>> dpp-common.c. There are no logical changes but some adaptations
>> needed to be made in order to isolate the encapsulating protocol
>> from the common protocol.
>>
>>   - The DPP header is now reduced to not include the mmpdu header
>>     or catagory byte.
>>   - A channel switch must now notify the encapsulating protocol
>>     since DPP common has no concept of frequency/channels
>>   - When a peer is accepted its up to the encapsulating protocol
>>     to filter frames only from this peer for the remainder of the
>>     protocol. With PKEX the peer/own MACs actually do need to be
>>     communicated to dpp-common due to some of the key generation.
>>   - When a PKEX key is not set into the SM its up to the
>>     encapsulating protocol to provide the key after a
>>     PKEX_KEY_REQUESTED event. Once the key is obtained the SM
>>     can resume the PKEX protocol.
>>
>
> There's a lot going on here, I think you're going to need to come up 
> with a different strategy and break this patch up into digestible chunks.
>
Sure, I tried, but its just a nasty build breaking change :)

I can try and make some of the improvements ahead of time, add frame 
handlers separately (auth/pkex/config/etc), then add the different events.

Thanks,

James