Re: [PATCH 6/9] dpp-common: add TX/RX handlers to dpp_sm

[Denis Kenzior <denkenz@gmail.com>]

Hi James,

On 3/27/24 10:19, James Prestwood wrote:
> This copies the bulk of the protocol handling from dpp.c into
> dpp-common.c. There are no logical changes but some adaptations
> needed to be made in order to isolate the encapsulating protocol
> from the common protocol.
> 
>   - The DPP header is now reduced to not include the mmpdu header
>     or catagory byte.
>   - A channel switch must now notify the encapsulating protocol
>     since DPP common has no concept of frequency/channels
>   - When a peer is accepted its up to the encapsulating protocol
>     to filter frames only from this peer for the remainder of the
>     protocol. With PKEX the peer/own MACs actually do need to be
>     communicated to dpp-common due to some of the key generation.
>   - When a PKEX key is not set into the SM its up to the
>     encapsulating protocol to provide the key after a
>     PKEX_KEY_REQUESTED event. Once the key is obtained the SM
>     can resume the PKEX protocol.
>

There's a lot going on here, I think you're going to need to come up with a 
different strategy and break this patch up into digestible chunks.

> Other changes were made for readability. Sending/handler function
> names were made consistent. The DPP config header is now built
> and parsed with common functions (as opposed to manually). Extra
> validation here and there was added as it was noticed (checks for
> required attributes, return value checks, etc).

Much of this can likely be done in separate steps.

> ---
>   src/dpp-common.c | 2246 +++++++++++++++++++++++++++++++++++++++++++++-

I'm not taking or reviewing a 2kloc patch :)

>   1 file changed, 2242 insertions(+), 4 deletions(-)
> 

Regards,
-Denis