From: Daniel Gomez <da.gomez@kernel.org>
To: Luis Chamberlain <mcgrof@kernel.org>,
Chuck Lever <chuck.lever@oracle.com>
Cc: kdevops@lists.linux.dev, Daniel Gomez <da.gomez@kernel.org>,
Daniel Gomez <da.gomez@samsung.com>
Subject: [PATCH 4/8] nixos: destroy the libvirt domain before cleaning up local artefacts
Date: Thu, 23 Apr 2026 00:16:45 +0200 [thread overview]
Message-ID: <20260423-kdevops-series-a-fixes-v1-4-69a82d0e1631@samsung.com> (raw)
In-Reply-To: <20260423-kdevops-series-a-fixes-v1-0-69a82d0e1631@samsung.com>
From: Daniel Gomez <da.gomez@samsung.com>
The destroy play tore down the local disk image, wrapper script
and symlink but never told libvirt about it, so domains brought
up through the libvirt bringup path stayed defined and running
after make destroy reported success. Add virsh destroy and virsh
undefine under the same LIBVIRT_DEFAULT_URI the bringup play
uses, both failed_when: false so a partial state across the
guest inventory does not abort the rest of the teardown.
Fixes: 3089c3fec57 ("nixos: add NixOS support as third bringup option with libvirt integration")
Generated-by: Claude AI
Signed-off-by: Daniel Gomez <da.gomez@samsung.com>
---
playbooks/nixos.yml | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/playbooks/nixos.yml b/playbooks/nixos.yml
index 26285520..d6aa2283 100644
--- a/playbooks/nixos.yml
+++ b/playbooks/nixos.yml
@@ -471,6 +471,20 @@
- "{{ playbook_dir }}/../extra_vars.yaml"
tags: [destroy, never]
tasks:
+ - name: Shut down VMs via libvirt
+ ansible.builtin.command: virsh destroy "{{ item }}"
+ loop: "{{ groups['all'] | reject('equalto', 'localhost') | list }}"
+ failed_when: false
+ environment:
+ LIBVIRT_DEFAULT_URI: "{{ libvirt_uri }}"
+
+ - name: Remove VM definitions from libvirt
+ ansible.builtin.command: virsh undefine "{{ item }}"
+ loop: "{{ groups['all'] | reject('equalto', 'localhost') | list }}"
+ failed_when: false
+ environment:
+ LIBVIRT_DEFAULT_URI: "{{ libvirt_uri }}"
+
- name: Stop VMs using wrapper scripts
ansible.builtin.command: "{{ nixos_storage_dir }}/run-{{ item }}-wrapper.sh stop"
loop: "{{ groups['all'] | reject('equalto', 'localhost') | list }}"
--
2.53.0
next prev parent reply other threads:[~2026-04-22 22:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-22 22:16 [PATCH 0/8] kdevops: small NIXOS and gen_hosts fixes Daniel Gomez
2026-04-22 22:16 ` [PATCH 1/8] nixos: remove duplicate nixos_channel extra-var from Makefile Daniel Gomez
2026-04-22 22:16 ` [PATCH 2/8] nixos: do not emit comment-only recipe lines under $(Q) Daniel Gomez
2026-04-22 22:16 ` [PATCH 3/8] nixos: drop hardcoded qxl video model from libvirt XML Daniel Gomez
2026-04-22 22:16 ` Daniel Gomez [this message]
2026-04-22 22:16 ` [PATCH 5/8] gen_hosts: scope the python interpreter per inventory group Daniel Gomez
2026-04-22 22:16 ` [PATCH 6/8] gen_hosts: make the linux workflow node name follow bootlinux_builder Daniel Gomez
2026-04-22 22:16 ` [PATCH 7/8] defconfigs/nixos: name NIXOS hosts with the "nixos" prefix Daniel Gomez
2026-04-22 22:16 ` [PATCH 8/8] gen_hosts: drop sudo become on inventory owner refresh Daniel Gomez
2026-04-23 13:50 ` [PATCH 0/8] kdevops: small NIXOS and gen_hosts fixes Chuck Lever
2026-04-23 19:20 ` Daniel Gomez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260423-kdevops-series-a-fixes-v1-4-69a82d0e1631@samsung.com \
--to=da.gomez@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=da.gomez@samsung.com \
--cc=kdevops@lists.linux.dev \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox