public inbox for kernel-hardening@lists.openwall.com
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Vasiliy Kulikov <segoon@openwall.com>,
	kernel-hardening@lists.openwall.com,
	Randy Dunlap <rdunlap@xenotime.net>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	"Serge E. Hallyn" <serge.hallyn@canonical.com>,
	Daniel Lezcano <daniel.lezcano@free.fr>,
	Oleg Nesterov <oleg@redhat.com>, Tejun Heo <tj@kernel.org>,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org
Subject: [kernel-hardening] Re: [RFC] ipc: introduce shm_rmid_forced sysctl
Date: Fri, 1 Jul 2011 13:25:34 +0200	[thread overview]
Message-ID: <20110701112534.GG20990@elte.hu> (raw)
In-Reply-To: <20110629151436.9be479fb.akpm@linux-foundation.org>


* Andrew Morton <akpm@linux-foundation.org> wrote:

> > --- a/ipc/shm.c
> > +++ b/ipc/shm.c
> > @@ -74,6 +74,7 @@ void shm_init_ns(struct ipc_namespace *ns)
> >  	ns->shm_ctlmax = SHMMAX;
> >  	ns->shm_ctlall = SHMALL;
> >  	ns->shm_ctlmni = SHMMNI;
> > +	ns->shm_rmid_forced = 0;
> >  	ns->shm_tot = 0;
> >  	ipc_init_ids(&shm_ids(ns));
> >  }
> 
> The problem is that nobody will test your feature.  So for testing
> purposes, let's enable the feature by default.  I assume this:

I'd also strongly argue to keep this as a default. OOM-kills are not 
part of POSIX and violate POSIX in a number of ways already.

Furthermore, if testing shows that this is not actually breaking 
anything in a serious way we could also in theory simplify the patch 
and just make this the default behavior with no runtime ability to 
switch it off.

Thanks,

	Ingo

  parent reply	other threads:[~2011-07-01 11:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-22 15:25 [kernel-hardening] [RFC] ipc: introduce shm_rmid_forced sysctl Vasiliy Kulikov
2011-06-22 16:03 ` [kernel-hardening] " Randy Dunlap
2011-06-29 22:14 ` Andrew Morton
2011-06-30  9:21   ` Vasiliy Kulikov
2011-06-30 13:08     ` Vasiliy Kulikov
2011-07-01 11:25   ` Ingo Molnar [this message]
2011-07-01 11:35     ` Vasiliy Kulikov
2011-07-01 12:04       ` Ingo Molnar
2011-07-01 14:18         ` Alan Cox
2011-07-03 19:38           ` Ingo Molnar
2011-07-03 21:25             ` Alan Cox
2011-07-02 16:50       ` Solar Designer
2011-07-02 17:31   ` Solar Designer
2011-07-04 15:08 ` Oleg Nesterov
2011-07-04 15:36   ` Vasiliy Kulikov
2011-07-04 15:44     ` Oleg Nesterov
2011-07-04 16:06       ` Vasiliy Kulikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110701112534.GG20990@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@linux-foundation.org \
    --cc=daniel.lezcano@free.fr \
    --cc=ebiederm@xmission.com \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=rdunlap@xenotime.net \
    --cc=segoon@openwall.com \
    --cc=serge.hallyn@canonical.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox