* [kernel-hardening] [PATCH] PCI: Fix typo in pax_open/close_kernel wrapping
@ 2017-03-01 20:33 Kees Cook
2017-03-01 21:45 ` [kernel-hardening] " PaX Team
0 siblings, 1 reply; 5+ messages in thread
From: Kees Cook @ 2017-03-01 20:33 UTC (permalink / raw)
To: pageexec; +Cc: spender, Mark Rutland, Hoeun Ryu, kernel-hardening
This fixes a mistaken double-open in PaX's constification coverage of
cpcihp_zt5550.
Signed-off-by: Kees Cook <kees@outflux.net>
---
drivers/pci/hotplug/cpcihp_zt5550.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/hotplug/cpcihp_zt5550.c b/drivers/pci/hotplug/cpcihp_zt5550.c
index 438f019..18c4d10 100644
--- a/drivers/pci/hotplug/cpcihp_zt5550.c
+++ b/drivers/pci/hotplug/cpcihp_zt5550.c
@@ -228,7 +228,7 @@ static int zt5550_hc_init_one(struct pci_dev *pdev, const struct pci_device_id *
const_cast(zt5550_hpc_ops.enable_irq) = zt5550_hc_enable_irq;
const_cast(zt5550_hpc_ops.disable_irq) = zt5550_hc_disable_irq;
const_cast(zt5550_hpc_ops.check_irq) = zt5550_hc_check_irq;
- pax_open_kernel();
+ pax_close_kernel();
} else {
info("using ENUM# polling mode");
}
--
2.7.4
--
Kees Cook
Pixel Security
^ permalink raw reply related [flat|nested] 5+ messages in thread* [kernel-hardening] Re: [PATCH] PCI: Fix typo in pax_open/close_kernel wrapping
2017-03-01 20:33 [kernel-hardening] [PATCH] PCI: Fix typo in pax_open/close_kernel wrapping Kees Cook
@ 2017-03-01 21:45 ` PaX Team
2017-03-01 22:46 ` Kees Cook
0 siblings, 1 reply; 5+ messages in thread
From: PaX Team @ 2017-03-01 21:45 UTC (permalink / raw)
To: Kees Cook; +Cc: spender, Mark Rutland, Hoeun Ryu, kernel-hardening
On 1 Mar 2017 at 12:33, Kees Cook wrote:
> This fixes a mistaken double-open in PaX's constification coverage of
> cpcihp_zt5550.
patch complains with:
checking file drivers/pci/hotplug/cpcihp_zt5550.c
Reversed (or previously applied) patch detected! Assume -R? [n]
are you sure you're looking at a recent tree?
^ permalink raw reply [flat|nested] 5+ messages in thread
* [kernel-hardening] Re: [PATCH] PCI: Fix typo in pax_open/close_kernel wrapping
2017-03-01 21:45 ` [kernel-hardening] " PaX Team
@ 2017-03-01 22:46 ` Kees Cook
2017-03-01 22:58 ` Kees Cook
0 siblings, 1 reply; 5+ messages in thread
From: Kees Cook @ 2017-03-01 22:46 UTC (permalink / raw)
To: PaX Team
Cc: Brad Spengler, Mark Rutland, Hoeun Ryu,
kernel-hardening@lists.openwall.com
On Wed, Mar 1, 2017 at 1:45 PM, PaX Team <pageexec@freemail.hu> wrote:
> On 1 Mar 2017 at 12:33, Kees Cook wrote:
>
>> This fixes a mistaken double-open in PaX's constification coverage of
>> cpcihp_zt5550.
>
> patch complains with:
>
> checking file drivers/pci/hotplug/cpcihp_zt5550.c
> Reversed (or previously applied) patch detected! Assume -R? [n]
>
> are you sure you're looking at a recent tree?
I guess not! Sorry for the noise. This was from pax-linux-4.9.9-test3.patch.
-Kees
--
Kees Cook
Pixel Security
^ permalink raw reply [flat|nested] 5+ messages in thread
* [kernel-hardening] Re: [PATCH] PCI: Fix typo in pax_open/close_kernel wrapping
2017-03-01 22:46 ` Kees Cook
@ 2017-03-01 22:58 ` Kees Cook
2017-03-01 23:14 ` PaX Team
0 siblings, 1 reply; 5+ messages in thread
From: Kees Cook @ 2017-03-01 22:58 UTC (permalink / raw)
To: PaX Team
Cc: Brad Spengler, Mark Rutland, Hoeun Ryu,
kernel-hardening@lists.openwall.com
On Wed, Mar 1, 2017 at 2:46 PM, Kees Cook <keescook@chromium.org> wrote:
> On Wed, Mar 1, 2017 at 1:45 PM, PaX Team <pageexec@freemail.hu> wrote:
>> On 1 Mar 2017 at 12:33, Kees Cook wrote:
>>
>>> This fixes a mistaken double-open in PaX's constification coverage of
>>> cpcihp_zt5550.
>>
>> patch complains with:
>>
>> checking file drivers/pci/hotplug/cpcihp_zt5550.c
>> Reversed (or previously applied) patch detected! Assume -R? [n]
>>
>> are you sure you're looking at a recent tree?
>
> I guess not! Sorry for the noise. This was from pax-linux-4.9.9-test3.patch.
Actually, it looks like it's an error in the grsecurity merge of PaX.
The mistake is present in the current grsecurity testing patch:
https://grsecurity.net/test/grsecurity-3.1-4.9.13-201702270729.patch
-Kees
--
Kees Cook
Pixel Security
^ permalink raw reply [flat|nested] 5+ messages in thread
* [kernel-hardening] Re: [PATCH] PCI: Fix typo in pax_open/close_kernel wrapping
2017-03-01 22:58 ` Kees Cook
@ 2017-03-01 23:14 ` PaX Team
0 siblings, 0 replies; 5+ messages in thread
From: PaX Team @ 2017-03-01 23:14 UTC (permalink / raw)
To: Kees Cook
Cc: Brad Spengler, Mark Rutland, Hoeun Ryu,
kernel-hardening@lists.openwall.com
On 1 Mar 2017 at 14:58, Kees Cook wrote:
> >> are you sure you're looking at a recent tree?
> >
> > I guess not! Sorry for the noise. This was from pax-linux-4.9.9-test3.patch.
>
> Actually, it looks like it's an error in the grsecurity merge of PaX.
> The mistake is present in the current grsecurity testing patch:
> https://grsecurity.net/test/grsecurity-3.1-4.9.13-201702270729.patch
he doesn't take such low priority fixes immediately (i found this regression
myself only a few days ago during the 4.10 port) but collects a few more of
them before making a new release.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-03-01 23:14 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-01 20:33 [kernel-hardening] [PATCH] PCI: Fix typo in pax_open/close_kernel wrapping Kees Cook
2017-03-01 21:45 ` [kernel-hardening] " PaX Team
2017-03-01 22:46 ` Kees Cook
2017-03-01 22:58 ` Kees Cook
2017-03-01 23:14 ` PaX Team
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox