From: James Morse <james.morse@arm.com>
To: kpark3469@gmail.com
Cc: kernel-hardening@lists.openwall.com, catalin.marinas@arm.com,
keescook@chromium.org, will.deacon@arm.com, mark.rutland@arm.com,
panand@redhat.com, keun-o.park@darkmatter.ae
Subject: [kernel-hardening] Re: [PATCH v3 2/3] arm64: usercopy: Implement stack frame object validation
Date: Tue, 07 Feb 2017 10:19:01 +0000 [thread overview]
Message-ID: <58999F15.3090807@arm.com> (raw)
In-Reply-To: <1486296850-16045-2-git-send-email-kpark3469@gmail.com>
On 05/02/17 12:14, kpark3469@gmail.com wrote:
> From: Sahara <keun-o.park@darkmatter.ae>
>
> This implements arch_within_stack_frames() for arm64 that should
> validate if a given object is contained by a kernel stack frame.
>
> Signed-off-by: Sahara <keun-o.park@darkmatter.ae>
> Reviewed-by: James Morse <james.morse@arm.com>
Careful, you should only include tags like this when they are explicitly given.
I don't remember doing that, and don't see it here:
http://www.openwall.com/lists/kernel-hardening/2017/01/26/8
I'd like to avoid having two sets of code that walk the stack.
I will have a go at a version of this patch that uses arm64s existing
walk_stackframe() machinery - lets find out if there is a good reason not to do
it that way!
Thanks,
James
next prev parent reply other threads:[~2017-02-07 10:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-05 12:14 [kernel-hardening] [PATCH v3 1/3] usercopy: create enum stack_type kpark3469
2017-02-05 12:14 ` [kernel-hardening] [PATCH v3 2/3] arm64: usercopy: Implement stack frame object validation kpark3469
2017-02-05 12:14 ` [kernel-hardening] [PATCH v3 3/3] lkdtm: add tests for dynamic array in local stack kpark3469
2017-02-06 22:22 ` [kernel-hardening] " Kees Cook
2017-02-06 22:34 ` [kernel-hardening] Re: [PATCH v3 2/3] arm64: usercopy: Implement stack frame object validation Kees Cook
2017-02-07 10:19 ` James Morse [this message]
2017-02-07 17:03 ` James Morse
2017-02-07 18:13 ` Kees Cook
2017-02-08 11:16 ` James Morse
2017-02-08 21:38 ` Kees Cook
2017-02-16 17:38 ` James Morse
2017-02-06 22:23 ` [kernel-hardening] Re: [PATCH v3 1/3] usercopy: create enum stack_type Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=58999F15.3090807@arm.com \
--to=james.morse@arm.com \
--cc=catalin.marinas@arm.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=keun-o.park@darkmatter.ae \
--cc=kpark3469@gmail.com \
--cc=mark.rutland@arm.com \
--cc=panand@redhat.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox