* Re: [PATCH v2] sched/core: Prioritize migrating eligible tasks in sched_balance_rq()
[not found] <20241223091446.90208-1-jiahao.kernel@gmail.com>
@ 2024-12-23 20:50 ` Markus Elfring
2024-12-24 1:53 ` Hao Jia
0 siblings, 1 reply; 3+ messages in thread
From: Markus Elfring @ 2024-12-23 20:50 UTC (permalink / raw)
To: Hao Jia, kernel-janitors, Ben Segall, Dietmar Eggemann,
Ingo Molnar, Juri Lelli, Mel Gorman, Peter Zijlstra,
Steven Rostedt, Valentin Schneider, Vincent Guittot
Cc: Hao Jia, LKML, Ingo Molnar
…
> All of the benchmarks are done inside a normal cpu cgroup in a
> clean environment with cpu turbo disabled, and test machine is:
…
CPU?
You may occasionally put more than 63 characters into text lines
of such a change description.
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] sched/core: Prioritize migrating eligible tasks in sched_balance_rq()
2024-12-23 20:50 ` [PATCH v2] sched/core: Prioritize migrating eligible tasks in sched_balance_rq() Markus Elfring
@ 2024-12-24 1:53 ` Hao Jia
2024-12-24 8:55 ` [v2] " Markus Elfring
0 siblings, 1 reply; 3+ messages in thread
From: Hao Jia @ 2024-12-24 1:53 UTC (permalink / raw)
To: Markus Elfring, Hao Jia, kernel-janitors, Ben Segall,
Dietmar Eggemann, Ingo Molnar, Juri Lelli, Mel Gorman,
Peter Zijlstra, Steven Rostedt, Valentin Schneider,
Vincent Guittot
Cc: LKML, Ingo Molnar
On 2024/12/24 04:50, Markus Elfring wrote:
> …
>> All of the benchmarks are done inside a normal cpu cgroup in a
>> clean environment with cpu turbo disabled, and test machine is:
> …
> CPU?
Thanks for your review, will fix it.
>
> You may occasionally put more than 63 characters into text lines
> of such a change description.
I checked the patch using ./scripts/checkpatch.pl before sending it, and
found no warnings or errors. The commit log should preferably have less
than 75 characters per line. If I'm wrong, please correct me, thank you.
Thanks,
Hao
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [v2] sched/core: Prioritize migrating eligible tasks in sched_balance_rq()
2024-12-24 1:53 ` Hao Jia
@ 2024-12-24 8:55 ` Markus Elfring
0 siblings, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2024-12-24 8:55 UTC (permalink / raw)
To: Hao Jia, kernel-janitors, Ben Segall, Dietmar Eggemann,
Ingo Molnar, Juri Lelli, Mel Gorman, Peter Zijlstra,
Steven Rostedt, Valentin Schneider, Vincent Guittot
Cc: Hao Jia, LKML, Ingo Molnar
>> You may occasionally put more than 63 characters into text lines
>> of such a change description.
>
> I checked the patch using ./scripts/checkpatch.pl before sending it, and found no warnings or errors. The commit log should preferably have less than 75 characters per line.
Can any texts look nicer if word wrapping would be accordingly adjusted a bit more?
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-24 8:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20241223091446.90208-1-jiahao.kernel@gmail.com>
2024-12-23 20:50 ` [PATCH v2] sched/core: Prioritize migrating eligible tasks in sched_balance_rq() Markus Elfring
2024-12-24 1:53 ` Hao Jia
2024-12-24 8:55 ` [v2] " Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox