kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [KJ] [Patch 2/12] BUG_ON() Conversion in fs/configfs/
@ 2006-01-27  9:32 Eric Sesterhenn / snakebyte
  0 siblings, 0 replies; only message in thread
From: Eric Sesterhenn / snakebyte @ 2006-01-27  9:32 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 1041 bytes --]

hi,

this changes if() BUG(); constructs to BUG_ON() which is
cleaner, contains unlikely() and can better optimized away.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>

--- linux-2.6.16-rc1-git4/fs/configfs/inode.c.orig	2006-01-27 01:24:58.000000000 +0100
+++ linux-2.6.16-rc1-git4/fs/configfs/inode.c	2006-01-27 01:25:10.000000000 +0100
@@ -105,8 +105,7 @@ const unsigned char * configfs_get_name(
 {
 	struct attribute * attr;
 
-	if (!sd || !sd->s_element)
-		BUG();
+	BUG_ON(!sd || !sd->s_element);
 
 	/* These always have a dentry, so use that */
 	if (sd->s_type & (CONFIGFS_DIR | CONFIGFS_ITEM_LINK))
--- linux-2.6.16-rc1-git4/fs/configfs/symlink.c.orig	2006-01-27 01:25:28.000000000 +0100
+++ linux-2.6.16-rc1-git4/fs/configfs/symlink.c	2006-01-27 01:25:46.000000000 +0100
@@ -162,8 +162,7 @@ int configfs_unlink(struct inode *dir, s
 	if (!(sd->s_type & CONFIGFS_ITEM_LINK))
 		goto out;
 
-	if (dentry->d_parent == configfs_sb->s_root)
-		BUG();
+	BUG_ON(dentry->d_parent == configfs_sb->s_root);
 
 	sl = sd->s_element;
 



[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2006-01-27  9:32 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-27  9:32 [KJ] [Patch 2/12] BUG_ON() Conversion in fs/configfs/ Eric Sesterhenn / snakebyte

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).