* [KJ] [Patch 2/5] BUG_ON() Conversion in
@ 2006-01-31 17:58 Eric Sesterhenn / snakebyte
0 siblings, 0 replies; only message in thread
From: Eric Sesterhenn / snakebyte @ 2006-01-31 17:58 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]
hi,
this changes if() BUG(); constructs to BUG_ON() which is
cleaner, contains unlikely() and can better optimized away.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.16-rc1-git4/drivers/s390/block/dasd_devmap.c.orig 2006-01-31 16:25:48.000000000 +0100
+++ linux-2.6.16-rc1-git4/drivers/s390/block/dasd_devmap.c 2006-01-31 16:26:43.000000000 +0100
@@ -435,8 +435,7 @@ dasd_forget_ranges(void)
spin_lock(&dasd_devmap_lock);
for (i = 0; i < 256; i++) {
list_for_each_entry_safe(devmap, n, &dasd_hashlists[i], list) {
- if (devmap->device != NULL)
- BUG();
+ BUG_ON(devmap->device != NULL);
list_del(&devmap->list);
kfree(devmap);
}
@@ -545,8 +544,7 @@ dasd_delete_device(struct dasd_device *d
/* First remove device pointer from devmap. */
devmap = dasd_find_busid(device->cdev->dev.bus_id);
- if (IS_ERR(devmap))
- BUG();
+ BUG_ON(IS_ERR(devmap));
spin_lock(&dasd_devmap_lock);
if (devmap->device != device) {
spin_unlock(&dasd_devmap_lock);
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-01-31 17:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-31 17:58 [KJ] [Patch 2/5] BUG_ON() Conversion in Eric Sesterhenn / snakebyte
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).