* [KJ] [Patch] BUG_ON() Conversion in sound/sparc/cs4231.c
@ 2006-01-31 17:59 Eric Sesterhenn / snakebyte
0 siblings, 0 replies; only message in thread
From: Eric Sesterhenn / snakebyte @ 2006-01-31 17:59 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]
hi,
this changes if() BUG(); constructs to BUG_ON() which is
cleaner, contains unlikely() and can better optimized away.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.16-rc1-git4/sound/sparc/cs4231.c.orig 2006-01-31 14:14:04.000000000 +0100
+++ linux-2.6.16-rc1-git4/sound/sparc/cs4231.c 2006-01-31 14:14:28.000000000 +0100
@@ -610,8 +610,7 @@ static void snd_cs4231_advance_dma(struc
unsigned int period_size = snd_pcm_lib_period_bytes(substream);
unsigned int offset = period_size * (*periods_sent);
- if (period_size >= (1 << 24))
- BUG();
+ BUG_ON(period_size >= (1 << 24));
if (dma_cont->request(dma_cont, runtime->dma_addr + offset, period_size))
return;
@@ -1078,8 +1077,7 @@ static int snd_cs4231_playback_prepare(s
chip->image[CS4231_IFACE_CTRL] &= ~(CS4231_PLAYBACK_ENABLE |
CS4231_PLAYBACK_PIO);
- if (runtime->period_size > 0xffff + 1)
- BUG();
+ BUG_ON(runtime->period_size > 0xffff + 1);
chip->p_periods_sent = 0;
spin_unlock_irqrestore(&chip->lock, flags);
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-01-31 17:59 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-01-31 17:59 [KJ] [Patch] BUG_ON() Conversion in sound/sparc/cs4231.c Eric Sesterhenn / snakebyte
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).