From: Emil Goode <emilgoode@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: [PATCH] staging: android: binder: fix some sparse warnings and long lines
Date: Mon, 23 Apr 2012 17:23:44 +0000 [thread overview]
Message-ID: <1335201824-17879-1-git-send-email-emilgoode@gmail.com> (raw)
This patch silences some sparse warnings and adds some line breaks
to take the 80 char limit coding style rule in consideration.
Signed-off-by: Emil Goode <emilgoode@gmail.com>
---
drivers/staging/android/binder.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
index c283212..5d31417 100644
--- a/drivers/staging/android/binder.c
+++ b/drivers/staging/android/binder.c
@@ -1600,15 +1600,21 @@ static void binder_transaction(struct binder_proc *proc,
case BINDER_TYPE_BINDER:
case BINDER_TYPE_WEAK_BINDER: {
struct binder_ref *ref;
- struct binder_node *node = binder_get_node(proc, fp->binder);
+ struct binder_node *node = binder_get_node(proc,
+ (void __user *)fp->binder);
if (node = NULL) {
- node = binder_new_node(proc, fp->binder, fp->cookie);
+ node = binder_new_node(proc,
+ (void __user *)fp->binder,
+ (void __user *)fp->cookie);
if (node = NULL) {
return_error = BR_FAILED_REPLY;
goto err_binder_new_node_failed;
}
- node->min_priority = fp->flags & FLAT_BINDER_FLAG_PRIORITY_MASK;
- node->accept_fds = !!(fp->flags & FLAT_BINDER_FLAG_ACCEPTS_FDS);
+ node->min_priority = fp->flags &
+ FLAT_BINDER_FLAG_PRIORITY_MASK;
+
+ node->accept_fds = !!(fp->flags &
+ FLAT_BINDER_FLAG_ACCEPTS_FDS);
}
if (fp->cookie != node->cookie) {
binder_user_error("binder: %d:%d sending u%p "
--
1.7.9.5
next reply other threads:[~2012-04-23 17:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 17:23 Emil Goode [this message]
2012-04-23 17:35 ` [PATCH] staging: android: binder: fix some sparse warnings and long lines Marcos Souza
2012-04-23 17:57 ` Dan Carpenter
2012-04-23 17:58 ` Dan Carpenter
2012-04-23 18:01 ` Marcos Souza
2012-04-23 18:12 ` Emil Goode
2012-04-23 18:17 ` Emil Goode
2012-04-23 18:23 ` Marcos Souza
2012-04-23 18:58 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1335201824-17879-1-git-send-email-emilgoode@gmail.com \
--to=emilgoode@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox