From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] staging: android: binder: fix some sparse warnings and long lines
Date: Mon, 23 Apr 2012 17:57:17 +0000 [thread overview]
Message-ID: <20120423175717.GX6498@mwanda> (raw)
In-Reply-To: <1335201824-17879-1-git-send-email-emilgoode@gmail.com>
On Mon, Apr 23, 2012 at 07:23:44PM +0200, Emil Goode wrote:
> This patch silences some sparse warnings and adds some line breaks
> to take the 80 char limit coding style rule in consideration.
>
Don't mix long line changes and sparse changes.
You missed some fp->binder casts so there are still Sparse warnings.
Anyway, these sparse annotations should probably go into the
struct binder_node definition in the .h file instead of always
casting. (I haven't verified. So be careful).
Don't forget to get to run your patches through checkpatch.pl before
sending them. (There are whitespace problems in your patch).
regards,
dan carpenter
next prev parent reply other threads:[~2012-04-23 17:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 17:23 [PATCH] staging: android: binder: fix some sparse warnings and long lines Emil Goode
2012-04-23 17:35 ` Marcos Souza
2012-04-23 17:57 ` Dan Carpenter [this message]
2012-04-23 17:58 ` Dan Carpenter
2012-04-23 18:01 ` Marcos Souza
2012-04-23 18:12 ` Emil Goode
2012-04-23 18:17 ` Emil Goode
2012-04-23 18:23 ` Marcos Souza
2012-04-23 18:58 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423175717.GX6498@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox