Re: [powerpc:next 11/29] arch/powerpc/platforms/pseries/iommu.c:1064:2: error: implicit declaration

Re: [powerpc:next 11/29] arch/powerpc/platforms/pseries/iommu.c:1064:2: error: implicit declaration

[Benjamin Herrenschmidt]

On Thu, 2012-09-06 at 10:20 +0800, Fengguang Wu wrote:
> Hi Michael,
> 
> FYI, kernel build failed on
> 
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git next
> head:   8b64a9dfb091f1eca8b7e58da82f1e7d1d5fe0ad
> commit: 474e3d569b63f7275cfec072d7ef7b2ffb8904c8 [11/29] powerpc/pseries: Remove uses of abs_to_virt() and virt_to_abs()
> config: powerpc-allmodconfig (attached as .config)
> 
> All related error/warning messages:
> 
> arch/powerpc/platforms/pseries/iommu.c: In function 'enable_ddw':
> arch/powerpc/platforms/pseries/iommu.c:1064:2: error: implicit declaration of function 'memblock_end_of_DRAM' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors

Thanks. That seems to be building in my tree oddly, I didn't even have a
warning. Maybe some conditional inclusion ? I will add a commit that
adds an explicit #include of memblock.h

Cheers,
Ben.

Re: [powerpc:next 11/29] arch/powerpc/platforms/pseries/iommu.c:1064:2: error: implicit declaration

[Benjamin Herrenschmidt]

On Thu, 2012-09-06 at 12:44 +1000, Benjamin Herrenschmidt wrote:
> On Thu, 2012-09-06 at 10:20 +0800, Fengguang Wu wrote:
> > Hi Michael,
> > 
> > FYI, kernel build failed on
> > 
> > tree:   git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git next
> > head:   8b64a9dfb091f1eca8b7e58da82f1e7d1d5fe0ad
> > commit: 474e3d569b63f7275cfec072d7ef7b2ffb8904c8 [11/29] powerpc/pseries: Remove uses of abs_to_virt() and virt_to_abs()
> > config: powerpc-allmodconfig (attached as .config)
> > 
> > All related error/warning messages:
> > 
> > arch/powerpc/platforms/pseries/iommu.c: In function 'enable_ddw':
> > arch/powerpc/platforms/pseries/iommu.c:1064:2: error: implicit declaration of function 'memblock_end_of_DRAM' [-Werror=implicit-function-declaration]
> > cc1: some warnings being treated as errors
> 
> Thanks. That seems to be building in my tree oddly, I didn't even have a
> warning. Maybe some conditional inclusion ? I will add a commit that
> adds an explicit #include of memblock.h

Ok, I see. It's a subtle bisection breakage, the next commit fixes it.
Oh well, I won't rebase for that, but thanks for the heads up.

Cheers,
Ben.

Re: [powerpc:next 11/29] arch/powerpc/platforms/pseries/iommu.c:1064:2: error: implicit declaration

[Fengguang Wu]

On Thu, Sep 06, 2012 at 12:49:14PM +1000, Benjamin Herrenschmidt wrote:
> On Thu, 2012-09-06 at 12:44 +1000, Benjamin Herrenschmidt wrote:
> > On Thu, 2012-09-06 at 10:20 +0800, Fengguang Wu wrote:
> > > Hi Michael,
> > > 
> > > FYI, kernel build failed on
> > > 
> > > tree:   git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc.git next
> > > head:   8b64a9dfb091f1eca8b7e58da82f1e7d1d5fe0ad
> > > commit: 474e3d569b63f7275cfec072d7ef7b2ffb8904c8 [11/29] powerpc/pseries: Remove uses of abs_to_virt() and virt_to_abs()
> > > config: powerpc-allmodconfig (attached as .config)
> > > 
> > > All related error/warning messages:
> > > 
> > > arch/powerpc/platforms/pseries/iommu.c: In function 'enable_ddw':
> > > arch/powerpc/platforms/pseries/iommu.c:1064:2: error: implicit declaration of function 'memblock_end_of_DRAM' [-Werror=implicit-function-declaration]
> > > cc1: some warnings being treated as errors
> > 
> > Thanks. That seems to be building in my tree oddly, I didn't even have a
> > warning. Maybe some conditional inclusion ? I will add a commit that
> > adds an explicit #include of memblock.h
> 
> Ok, I see. It's a subtle bisection breakage, the next commit fixes it.

Yes, I'm doing bisectibility tests :)

> Oh well, I won't rebase for that, but thanks for the heads up.

No problem. Sorry I didn't know that. Will test HEAD commits only for
this branch in future.

Thanks,
Fengguang

Re: [powerpc:next 11/29] arch/powerpc/platforms/pseries/iommu.c:1064:2: error: implicit declaration

[Benjamin Herrenschmidt]

On Thu, 2012-09-06 at 11:03 +0800, Fengguang Wu wrote:
> 
> No problem. Sorry I didn't know that. Will test HEAD commits only for
> this branch in future.

Actually, I'd rather you continue doing bisection tests, it's good, I
can whack on the head of people who submit stuff with breakage.

In fact, next time around, I'll try to be more pro-active at putting
things in my rebase-able test branch so you get a chance to run your
tests on it and we can find & fix these before it hits next. I'll let
you know when I do it.

In the meantime, maybe just blacklist those commits ?

Cheers,
Ben.

Re: [powerpc:next 11/29] arch/powerpc/platforms/pseries/iommu.c:1064:2: error: implicit declaration

[Fengguang Wu]

On Thu, Sep 06, 2012 at 01:05:56PM +1000, Benjamin Herrenschmidt wrote:
> On Thu, 2012-09-06 at 11:03 +0800, Fengguang Wu wrote:
> > 
> > No problem. Sorry I didn't know that. Will test HEAD commits only for
> > this branch in future.
> 
> Actually, I'd rather you continue doing bisection tests, it's good, I
> can whack on the head of people who submit stuff with breakage.

OK.

> In fact, next time around, I'll try to be more pro-active at putting
> things in my rebase-able test branch so you get a chance to run your
> tests on it and we can find & fix these before it hits next. I'll let
> you know when I do it.

That would be great.

> In the meantime, maybe just blacklist those commits ?

Should not necessary if I understand you right. FYI the build system
will auto ignore all notified build errors and skip compiled commits.


Thanks,
Fengguang