From: Andreas Platschek <andi.platschek@gmail.com>
To: gregkh@linuxfoundation.org
Cc: jslaby@suse.cz, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Andreas Platschek <andi.platschek@gmail.com>
Subject: [PATCH] tty: replace mutex_lock() with tty_write_lock()
Date: Thu, 21 Nov 2013 19:12:12 +0000 [thread overview]
Message-ID: <1385061132-7254-1-git-send-email-andi.platschek@gmail.com> (raw)
Use tty_write_lock()/tty_write_unlock() consistently.
This takes care of the following sparse warning:
drivers/tty/tty_io.c:1169:17: warning: context imbalance in 'tty_write_message' - unexpected unlock
Signed-off-by: Andreas Platschek <andi.platschek@gmail.com>
---
drivers/tty/tty_io.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/tty_io.c b/drivers/tty/tty_io.c
index 3a1a01a..13dca92 100644
--- a/drivers/tty/tty_io.c
+++ b/drivers/tty/tty_io.c
@@ -1165,7 +1165,7 @@ out:
void tty_write_message(struct tty_struct *tty, char *msg)
{
if (tty) {
- mutex_lock(&tty->atomic_write_lock);
+ tty_write_lock(tty,0);
tty_lock(tty);
if (tty->ops->write && !test_bit(TTY_CLOSING, &tty->flags)) {
tty_unlock(tty);
--
1.7.10.4
next reply other threads:[~2013-11-21 19:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 19:12 Andreas Platschek [this message]
2013-11-22 8:09 ` [PATCH] tty: replace mutex_lock() with tty_write_lock() walter harms
2013-11-22 8:22 ` Andreas Platschek
2013-11-22 8:29 ` Dan Carpenter
2013-11-22 8:25 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1385061132-7254-1-git-send-email-andi.platschek@gmail.com \
--to=andi.platschek@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox