From: Dan Carpenter <dan.carpenter@oracle.com>
To: Andreas Platschek <andi.platschek@gmail.com>
Cc: gregkh@linuxfoundation.org, jslaby@suse.cz,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] tty: replace mutex_lock() with tty_write_lock()
Date: Fri, 22 Nov 2013 08:25:25 +0000 [thread overview]
Message-ID: <20131122082525.GA5302@mwanda> (raw)
In-Reply-To: <1385061132-7254-1-git-send-email-andi.platschek@gmail.com>
On Thu, Nov 21, 2013 at 08:12:12PM +0100, Andreas Platschek wrote:
> Use tty_write_lock()/tty_write_unlock() consistently.
>
> This takes care of the following sparse warning:
> drivers/tty/tty_io.c:1169:17: warning: context imbalance in 'tty_write_message' - unexpected unlock
>
I don't think we can do this. mutex_lock() always succeeds and
tty_write_lock() can fail.
I think we just have to live with the error message.
regards,
dan carpenter
prev parent reply other threads:[~2013-11-22 8:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-21 19:12 [PATCH] tty: replace mutex_lock() with tty_write_lock() Andreas Platschek
2013-11-22 8:09 ` walter harms
2013-11-22 8:22 ` Andreas Platschek
2013-11-22 8:29 ` Dan Carpenter
2013-11-22 8:25 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131122082525.GA5302@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andi.platschek@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox