* [patch 1/2] ASoC: sst-haswell-ipc: restore IRQs on error
@ 2014-02-25 8:32 Dan Carpenter
2014-02-25 13:12 ` [alsa-devel] " Liam Girdwood
2014-02-25 23:46 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2014-02-25 8:32 UTC (permalink / raw)
To: Liam Girdwood; +Cc: Takashi Iwai, alsa-devel, Mark Brown, kernel-janitors
This should be spin_unlock_irqrestore() instead of spin_unlock()
Fixes: 22981243589c ('ASoC: Intel: Add Haswell/Broadwell IPC')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/sound/soc/intel/sst-haswell-ipc.c b/sound/soc/intel/sst-haswell-ipc.c
index 668d486520ae..552aebf2c8f5 100644
--- a/sound/soc/intel/sst-haswell-ipc.c
+++ b/sound/soc/intel/sst-haswell-ipc.c
@@ -527,7 +527,7 @@ static int ipc_tx_message(struct sst_hsw *hsw, u32 header, void *tx_data,
msg = msg_get_empty(hsw);
if (msg = NULL) {
- spin_unlock(&hsw->dsp->spinlock);
+ spin_unlock_irqrestore(&hsw->dsp->spinlock, flags);
return -EBUSY;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [alsa-devel] [patch 1/2] ASoC: sst-haswell-ipc: restore IRQs on error
2014-02-25 8:32 [patch 1/2] ASoC: sst-haswell-ipc: restore IRQs on error Dan Carpenter
@ 2014-02-25 13:12 ` Liam Girdwood
2014-02-25 23:46 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2014-02-25 13:12 UTC (permalink / raw)
To: Dan Carpenter
Cc: Liam Girdwood, Takashi Iwai, alsa-devel, Mark Brown,
kernel-janitors
T24gVHVlLCAyMDE0LTAyLTI1IGF0IDExOjMyICswMzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOgo+
IFRoaXMgc2hvdWxkIGJlIHNwaW5fdW5sb2NrX2lycXJlc3RvcmUoKSBpbnN0ZWFkIG9mIHNwaW5f
dW5sb2NrKCkKPiAKPiBGaXhlczogMjI5ODEyNDM1ODljICgnQVNvQzogSW50ZWw6IEFkZCBIYXN3
ZWxsL0Jyb2Fkd2VsbCBJUEMnKQo+IFNpZ25lZC1vZmYtYnk6IERhbiBDYXJwZW50ZXIgPGRhbi5j
YXJwZW50ZXJAb3JhY2xlLmNvbT4KPiAKPiBkaWZmIC0tZ2l0IGEvc291bmQvc29jL2ludGVsL3Nz
dC1oYXN3ZWxsLWlwYy5jIGIvc291bmQvc29jL2ludGVsL3NzdC1oYXN3ZWxsLWlwYy5jCj4gaW5k
ZXggNjY4ZDQ4NjUyMGFlLi41NTJhZWJmMmM4ZjUgMTAwNjQ0Cj4gLS0tIGEvc291bmQvc29jL2lu
dGVsL3NzdC1oYXN3ZWxsLWlwYy5jCj4gKysrIGIvc291bmQvc29jL2ludGVsL3NzdC1oYXN3ZWxs
LWlwYy5jCj4gQEAgLTUyNyw3ICs1MjcsNyBAQCBzdGF0aWMgaW50IGlwY190eF9tZXNzYWdlKHN0
cnVjdCBzc3RfaHN3ICpoc3csIHUzMiBoZWFkZXIsIHZvaWQgKnR4X2RhdGEsCj4gIAo+ICAJbXNn
ID0gbXNnX2dldF9lbXB0eShoc3cpOwo+ICAJaWYgKG1zZyA9PSBOVUxMKSB7Cj4gLQkJc3Bpbl91
bmxvY2soJmhzdy0+ZHNwLT5zcGlubG9jayk7Cj4gKwkJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgm
aHN3LT5kc3AtPnNwaW5sb2NrLCBmbGFncyk7Cj4gIAkJcmV0dXJuIC1FQlVTWTsKPiAgCX0KPiAg
CgpCb3RoIAoKQWNrZWQtYnk6IExpYW0gR2lyZHdvb2QgPGxpYW0uci5naXJkd29vZEBsaW51eC5p
bnRlbC5jb20+CgoKLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t
LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCkludGVsIENvcnBvcmF0aW9uIChVSykgTGltaXRlZApS
ZWdpc3RlcmVkIE5vLiAxMTM0OTQ1IChFbmdsYW5kKQpSZWdpc3RlcmVkIE9mZmljZTogUGlwZXJz
IFdheSwgU3dpbmRvbiBTTjMgMVJKClZBVCBObzogODYwIDIxNzMgNDcKClRoaXMgZS1tYWlsIGFu
ZCBhbnkgYXR0YWNobWVudHMgbWF5IGNvbnRhaW4gY29uZmlkZW50aWFsIG1hdGVyaWFsIGZvcgp0
aGUgc29sZSB1c2Ugb2YgdGhlIGludGVuZGVkIHJlY2lwaWVudChzKS4gQW55IHJldmlldyBvciBk
aXN0cmlidXRpb24KYnkgb3RoZXJzIGlzIHN0cmljdGx5IHByb2hpYml0ZWQuIElmIHlvdSBhcmUg
bm90IHRoZSBpbnRlbmRlZApyZWNpcGllbnQsIHBsZWFzZSBjb250YWN0IHRoZSBzZW5kZXIgYW5k
IGRlbGV0ZSBhbGwgY29waWVzLgo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch 1/2] ASoC: sst-haswell-ipc: restore IRQs on error
2014-02-25 8:32 [patch 1/2] ASoC: sst-haswell-ipc: restore IRQs on error Dan Carpenter
2014-02-25 13:12 ` [alsa-devel] " Liam Girdwood
@ 2014-02-25 23:46 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-02-25 23:46 UTC (permalink / raw)
To: Dan Carpenter
Cc: Liam Girdwood, Jaroslav Kysela, Takashi Iwai, alsa-devel,
kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 153 bytes --]
On Tue, Feb 25, 2014 at 11:32:50AM +0300, Dan Carpenter wrote:
> This should be spin_unlock_irqrestore() instead of spin_unlock()
Applied both, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-02-25 23:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-25 8:32 [patch 1/2] ASoC: sst-haswell-ipc: restore IRQs on error Dan Carpenter
2014-02-25 13:12 ` [alsa-devel] " Liam Girdwood
2014-02-25 23:46 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox