From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Bastien Nocera <hadess@hadess.net>
Cc: Darren Hart <dvhart@infradead.org>,
ibm-acpi-devel@lists.sourceforge.net,
platform-driver-x86@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch 2/2] thinkpad_acpi: off by one in adaptive_keyboard_hotkey_notify_hotkey()
Date: Wed, 11 Mar 2015 10:27:32 +0000 [thread overview]
Message-ID: <1426069652.2792036.238809225.344CD11D@webmail.messagingengine.com> (raw)
In-Reply-To: <20150311093607.GB3564@mwanda>
On Wed, Mar 11, 2015, at 06:36, Dan Carpenter wrote:
> + if (scancode < FIRST_ADAPTIVE_KEY ||
> + scancode >= FIRST_ADAPTIVE_KEY +
> TPACPI_HOTKEY_MAP_LEN -
> + ADAPTIVE_KEY_OFFSET) {
Meh, I'd prefer that last linebreak to not be there, the 80-char rule is
meant to be ignored when it causes the code to be less readable.
That said,
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Thanks for the fix!
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2015-03-11 10:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 9:36 [patch 2/2] thinkpad_acpi: off by one in adaptive_keyboard_hotkey_notify_hotkey() Dan Carpenter
2015-03-11 10:26 ` Bastien Nocera
2015-03-11 10:27 ` Henrique de Moraes Holschuh [this message]
2015-03-14 19:03 ` Darren Hart
2015-03-22 19:01 ` [ibm-acpi-devel] [patch 2/2] thinkpad_acpi: off by one in adaptive_keyboard_hotkey_notify_hotkey Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1426069652.2792036.238809225.344CD11D@webmail.messagingengine.com \
--to=hmh@hmh.eng.br \
--cc=dan.carpenter@oracle.com \
--cc=dvhart@infradead.org \
--cc=hadess@hadess.net \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox