From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Bastien Nocera <hadess@hadess.net>
Cc: Darren Hart <dvhart@infradead.org>,
platform-driver-x86@vger.kernel.org,
kernel-janitors@vger.kernel.org,
ibm-acpi-devel@lists.sourceforge.net
Subject: Re: [ibm-acpi-devel] [patch 2/2] thinkpad_acpi: off by one in adaptive_keyboard_hotkey_notify_hotkey
Date: Sun, 22 Mar 2015 19:01:09 +0000 [thread overview]
Message-ID: <1427050869.3946795.243708250.7D9CBED0@webmail.messagingengine.com> (raw)
In-Reply-To: <20150311093607.GB3564@mwanda>
On Wed, Mar 11, 2015, at 06:36, Dan Carpenter wrote:
> This should be >= instead of > because otherwise we read one element
> past the end of the hotkey_keycode_map[] array.
>
> The hotkey_keycode_map[] array has TPACPI_HOTKEY_MAP_LEN elements.
>
> Fixes: 6a68d8557084 ('thinkpad_acpi: Add support for more adaptive kbd
> buttons')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
prev parent reply other threads:[~2015-03-22 19:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-11 9:36 [patch 2/2] thinkpad_acpi: off by one in adaptive_keyboard_hotkey_notify_hotkey() Dan Carpenter
2015-03-11 10:26 ` Bastien Nocera
2015-03-11 10:27 ` Henrique de Moraes Holschuh
2015-03-14 19:03 ` Darren Hart
2015-03-22 19:01 ` Henrique de Moraes Holschuh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1427050869.3946795.243708250.7D9CBED0@webmail.messagingengine.com \
--to=hmh@hmh.eng.br \
--cc=dan.carpenter@oracle.com \
--cc=dvhart@infradead.org \
--cc=hadess@hadess.net \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox