* [PATCH 1/2] driver: w1: fix quoted strings split across lines
@ 2016-07-23 22:45 Ben Werbowyj
2016-07-25 10:46 ` Vignesh R
2016-07-25 20:31 ` Ben Werbowyj
0 siblings, 2 replies; 3+ messages in thread
From: Ben Werbowyj @ 2016-07-23 22:45 UTC (permalink / raw)
To: kernel-janitors
Coding style corrections as indentified by checkpatch.pl scripts.
Quoted strings split across line.
Signed-off-by: Ben Werbowyj <ben.werbowyj@gmail.com>
---
drivers/w1/masters/omap_hdq.c | 23 +++++++++++++----------
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
index a2eec97..7d0987d 100644
--- a/drivers/w1/masters/omap_hdq.c
+++ b/drivers/w1/masters/omap_hdq.c
@@ -203,8 +203,9 @@ static int hdq_write_byte(struct hdq_data *hdq_data, u8 val, u8 *status)
*status = hdq_data->hdq_irqstatus;
/* check irqstatus */
if (!(*status & OMAP_HDQ_INT_STATUS_TXCOMPLETE)) {
- dev_dbg(hdq_data->dev, "timeout waiting for"
- " TXCOMPLETE/RXCOMPLETE, %x", *status);
+ dev_dbg(hdq_data->dev,
+ "timeout waiting for TXCOMPLETE/RXCOMPLETE, %x",
+ *status);
ret = -ETIMEDOUT;
goto out;
}
@@ -214,8 +215,9 @@ static int hdq_write_byte(struct hdq_data *hdq_data, u8 val, u8 *status)
OMAP_HDQ_CTRL_STATUS_GO,
OMAP_HDQ_FLAG_CLEAR, &tmp_status);
if (ret) {
- dev_dbg(hdq_data->dev, "timeout waiting GO bit"
- " return to zero, %x", tmp_status);
+ dev_dbg(hdq_data->dev,
+ "timeout waiting GO bit return to zero, %x",
+ tmp_status);
}
out:
@@ -365,8 +367,9 @@ static int omap_hdq_break(struct hdq_data *hdq_data)
OMAP_HDQ_CTRL_STATUS_GO, OMAP_HDQ_FLAG_CLEAR,
&tmp_status);
if (ret)
- dev_dbg(hdq_data->dev, "timeout waiting INIT&GO bits"
- " return to zero, %x", tmp_status);
+ dev_dbg(hdq_data->dev,
+ "timeout waiting INIT&GO bits return to zero, %x",
+ tmp_status);
out:
mutex_unlock(&hdq_data->hdq_mutex);
@@ -409,8 +412,8 @@ static int hdq_read_byte(struct hdq_data *hdq_data, u8 *val)
status = hdq_data->hdq_irqstatus;
/* check irqstatus */
if (!(status & OMAP_HDQ_INT_STATUS_RXCOMPLETE)) {
- dev_dbg(hdq_data->dev, "timeout waiting for"
- " RXCOMPLETE, %x", status);
+ dev_dbg(hdq_data->dev,
+ "timeout waiting for RXCOMPLETE, %x", status);
ret = -ETIMEDOUT;
goto out;
}
@@ -484,8 +487,8 @@ static int omap_hdq_put(struct hdq_data *hdq_data)
hdq_reg_out(hdq_data, OMAP_HDQ_SYSCONFIG,
OMAP_HDQ_SYSCONFIG_AUTOIDLE);
if (0 = hdq_data->hdq_usecount) {
- dev_dbg(hdq_data->dev, "attempt to decrement use count"
- " when it is zero");
+ dev_dbg(hdq_data->dev,
+ "attempt to decrement use count when it is zero");
ret = -EINVAL;
} else {
hdq_data->hdq_usecount--;
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] driver: w1: fix quoted strings split across lines
2016-07-23 22:45 [PATCH 1/2] driver: w1: fix quoted strings split across lines Ben Werbowyj
@ 2016-07-25 10:46 ` Vignesh R
2016-07-25 20:31 ` Ben Werbowyj
1 sibling, 0 replies; 3+ messages in thread
From: Vignesh R @ 2016-07-25 10:46 UTC (permalink / raw)
To: kernel-janitors
On Sunday 24 July 2016 04:15 AM, Ben Werbowyj wrote:
> Coding style corrections as indentified by checkpatch.pl scripts.
nit, s/indentified/identified
Regards
Vignesh
> Quoted strings split across line.
>
> Signed-off-by: Ben Werbowyj <ben.werbowyj@gmail.com>
> ---
> drivers/w1/masters/omap_hdq.c | 23 +++++++++++++----------
> 1 file changed, 13 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
> index a2eec97..7d0987d 100644
> --- a/drivers/w1/masters/omap_hdq.c
> +++ b/drivers/w1/masters/omap_hdq.c
> @@ -203,8 +203,9 @@ static int hdq_write_byte(struct hdq_data *hdq_data, u8 val, u8 *status)
> *status = hdq_data->hdq_irqstatus;
> /* check irqstatus */
> if (!(*status & OMAP_HDQ_INT_STATUS_TXCOMPLETE)) {
> - dev_dbg(hdq_data->dev, "timeout waiting for"
> - " TXCOMPLETE/RXCOMPLETE, %x", *status);
> + dev_dbg(hdq_data->dev,
> + "timeout waiting for TXCOMPLETE/RXCOMPLETE, %x",
> + *status);
> ret = -ETIMEDOUT;
> goto out;
> }
> @@ -214,8 +215,9 @@ static int hdq_write_byte(struct hdq_data *hdq_data, u8 val, u8 *status)
> OMAP_HDQ_CTRL_STATUS_GO,
> OMAP_HDQ_FLAG_CLEAR, &tmp_status);
> if (ret) {
> - dev_dbg(hdq_data->dev, "timeout waiting GO bit"
> - " return to zero, %x", tmp_status);
> + dev_dbg(hdq_data->dev,
> + "timeout waiting GO bit return to zero, %x",
> + tmp_status);
> }
>
> out:
> @@ -365,8 +367,9 @@ static int omap_hdq_break(struct hdq_data *hdq_data)
> OMAP_HDQ_CTRL_STATUS_GO, OMAP_HDQ_FLAG_CLEAR,
> &tmp_status);
> if (ret)
> - dev_dbg(hdq_data->dev, "timeout waiting INIT&GO bits"
> - " return to zero, %x", tmp_status);
> + dev_dbg(hdq_data->dev,
> + "timeout waiting INIT&GO bits return to zero, %x",
> + tmp_status);
>
> out:
> mutex_unlock(&hdq_data->hdq_mutex);
> @@ -409,8 +412,8 @@ static int hdq_read_byte(struct hdq_data *hdq_data, u8 *val)
> status = hdq_data->hdq_irqstatus;
> /* check irqstatus */
> if (!(status & OMAP_HDQ_INT_STATUS_RXCOMPLETE)) {
> - dev_dbg(hdq_data->dev, "timeout waiting for"
> - " RXCOMPLETE, %x", status);
> + dev_dbg(hdq_data->dev,
> + "timeout waiting for RXCOMPLETE, %x", status);
> ret = -ETIMEDOUT;
> goto out;
> }
> @@ -484,8 +487,8 @@ static int omap_hdq_put(struct hdq_data *hdq_data)
> hdq_reg_out(hdq_data, OMAP_HDQ_SYSCONFIG,
> OMAP_HDQ_SYSCONFIG_AUTOIDLE);
> if (0 = hdq_data->hdq_usecount) {
> - dev_dbg(hdq_data->dev, "attempt to decrement use count"
> - " when it is zero");
> + dev_dbg(hdq_data->dev,
> + "attempt to decrement use count when it is zero");
> ret = -EINVAL;
> } else {
> hdq_data->hdq_usecount--;
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 1/2] driver: w1: fix quoted strings split across lines
2016-07-23 22:45 [PATCH 1/2] driver: w1: fix quoted strings split across lines Ben Werbowyj
2016-07-25 10:46 ` Vignesh R
@ 2016-07-25 20:31 ` Ben Werbowyj
1 sibling, 0 replies; 3+ messages in thread
From: Ben Werbowyj @ 2016-07-25 20:31 UTC (permalink / raw)
To: kernel-janitors
Hi Vignesh,
On 25 July 2016 at 20:34, Vignesh R <vigneshr@ti.com> wrote:
>
>
> On Sunday 24 July 2016 04:15 AM, Ben Werbowyj wrote:
>> Coding style corrections as indentified by checkpatch.pl scripts.
>
> nit, s/indentified/identified
>
> Regards
> Vignesh
>
Apologies for that. Would you like me to correct it and re-submit the patch?
Ben
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-25 20:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-23 22:45 [PATCH 1/2] driver: w1: fix quoted strings split across lines Ben Werbowyj
2016-07-25 10:46 ` Vignesh R
2016-07-25 20:31 ` Ben Werbowyj
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox