* [PATCH -next] scsi: target/core: Use kmem_cache_free() instead of kfree()
@ 2018-12-17 12:19 Wei Yongjun
2018-12-17 16:16 ` Bart Van Assche
2018-12-19 3:53 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2018-12-17 12:19 UTC (permalink / raw)
To: target-devel
memory allocated by kmem_cache_alloc() should be freed using
kmem_cache_free(), not kfree().
Fixes: ad669505c4e9 ("scsi: target/core: Make sure that target_wait_for_sess_cmds() waits long enough")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/target/target_core_transport.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index 65a1819..ef9e75b 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -266,7 +266,7 @@ struct se_session *transport_alloc_session(enum target_prot_op sup_prot_ops)
}
ret = transport_init_session(se_sess);
if (ret < 0) {
- kfree(se_sess);
+ kmem_cache_free(se_sess_cache, se_sess);
return ERR_PTR(ret);
}
se_sess->sup_prot_ops = sup_prot_ops;
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH -next] scsi: target/core: Use kmem_cache_free() instead of kfree()
2018-12-17 12:19 [PATCH -next] scsi: target/core: Use kmem_cache_free() instead of kfree() Wei Yongjun
@ 2018-12-17 16:16 ` Bart Van Assche
2018-12-19 3:53 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Bart Van Assche @ 2018-12-17 16:16 UTC (permalink / raw)
To: target-devel
On Mon, 2018-12-17 at 12:19 +-0000, Wei Yongjun wrote:
+AD4 memory allocated by kmem+AF8-cache+AF8-alloc() should be freed using
+AD4 kmem+AF8-cache+AF8-free(), not kfree().
+AD4
+AD4 Fixes: ad669505c4e9 (+ACI-scsi: target/core: Make sure that target+AF8-wait+AF8-for+AF8-sess+AF8-cmds() waits long enough+ACI)
+AD4 Signed-off-by: Wei Yongjun +ADw-weiyongjun1+AEA-huawei.com+AD4
+AD4 ---
+AD4 drivers/target/target+AF8-core+AF8-transport.c +AHw 2 +--
+AD4 1 file changed, 1 insertion(+-), 1 deletion(-)
+AD4
+AD4 diff --git a/drivers/target/target+AF8-core+AF8-transport.c b/drivers/target/target+AF8-core+AF8-transport.c
+AD4 index 65a1819..ef9e75b 100644
+AD4 --- a/drivers/target/target+AF8-core+AF8-transport.c
+AD4 +-+-+- b/drivers/target/target+AF8-core+AF8-transport.c
+AD4 +AEAAQA -266,7 +-266,7 +AEAAQA struct se+AF8-session +ACo-transport+AF8-alloc+AF8-session(enum target+AF8-prot+AF8-op sup+AF8-prot+AF8-ops)
+AD4 +AH0
+AD4 ret +AD0 transport+AF8-init+AF8-session(se+AF8-sess)+ADs
+AD4 if (ret +ADw 0) +AHs
+AD4 - kfree(se+AF8-sess)+ADs
+AD4 +- kmem+AF8-cache+AF8-free(se+AF8-sess+AF8-cache, se+AF8-sess)+ADs
+AD4 return ERR+AF8-PTR(ret)+ADs
+AD4 +AH0
+AD4 se+AF8-sess-+AD4-sup+AF8-prot+AF8-ops +AD0 sup+AF8-prot+AF8-ops+ADs
Thanks for this patch.
Reviewed-by: Bart Van Assche +ADw-bvanassche+AEA-acm.org+AD4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] scsi: target/core: Use kmem_cache_free() instead of kfree()
2018-12-17 12:19 [PATCH -next] scsi: target/core: Use kmem_cache_free() instead of kfree() Wei Yongjun
2018-12-17 16:16 ` Bart Van Assche
@ 2018-12-19 3:53 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2018-12-19 3:53 UTC (permalink / raw)
To: target-devel
Wei,
> memory allocated by kmem_cache_alloc() should be freed using
> kmem_cache_free(), not kfree().
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-19 3:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-17 12:19 [PATCH -next] scsi: target/core: Use kmem_cache_free() instead of kfree() Wei Yongjun
2018-12-17 16:16 ` Bart Van Assche
2018-12-19 3:53 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox