From: Markus Elfring <Markus.Elfring@web.de>
To: Miquel Raynal <miquel.raynal@bootlin.com>, linux-mtd@lists.infradead.org
Cc: Vignesh Raghavendra <vigneshr@ti.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
Armijn Hemel <armijn@tjaldur.nl>,
Himanshu Jha <himanshujha199640@gmail.com>,
Richard Weinberger <richard@nod.at>,
Lee Jones <lee.jones@linaro.org>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Allison Randal <allison@lohutok.net>
Subject: Re: [PATCH] mtd: st_spi_fsm: Use devm_platform_ioremap_resource() in stfsm_probe()
Date: Thu, 19 Sep 2019 10:50:28 +0000 [thread overview]
Message-ID: <17a1fccd-0ac3-f257-dec9-228b33a18cfa@web.de> (raw)
In-Reply-To: <20190919111014.6c569cf3@xps13>
>> +++ b/drivers/mtd/devices/st_spi_fsm.c
>> @@ -2034,13 +2034,7 @@ static int stfsm_probe(struct platform_device *pdev)
>>
>> platform_set_drvdata(pdev, fsm);
>>
>> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> - if (!res) {
>> - dev_err(&pdev->dev, "Resource not found\n");
>> - return -ENODEV;
>> - }
>> -
>> - fsm->base = devm_ioremap_resource(&pdev->dev, res);
>> + fsm->base = devm_platform_ioremap_resource(pdev, 0);
>> if (IS_ERR(fsm->base)) {
>> dev_err(&pdev->dev,
>> "Failed to reserve memory region %pR\n", res);
>> --
>> 2.23.0
>>
>
>
> Is this even compiled tested? 'res' is not initialized anymore so you
> can't use it in the error trace. I suppose you should even drop it from
> the stack parameters.
Would you accept to reduce the error message another bit?
Regards,
Markus
next prev parent reply other threads:[~2019-09-19 10:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 12:50 [PATCH] mtd: st_spi_fsm: Use devm_platform_ioremap_resource() in stfsm_probe() Markus Elfring
2019-09-19 9:10 ` Miquel Raynal
2019-09-19 10:50 ` Markus Elfring [this message]
2019-09-19 11:29 ` Greg Kroah-Hartman
2019-09-19 11:35 ` Miquel Raynal
2019-09-19 12:16 ` Markus Elfring
2019-09-19 12:04 ` [PATCH v2] " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17a1fccd-0ac3-f257-dec9-228b33a18cfa@web.de \
--to=markus.elfring@web.de \
--cc=allison@lohutok.net \
--cc=armijn@tjaldur.nl \
--cc=bgolaszewski@baylibre.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=himanshujha199640@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox