From: Markus Elfring <Markus.Elfring@web.de>
To: Miquel Raynal <miquel.raynal@bootlin.com>,
Allison Randal <allison@lohutok.net>,
Armijn Hemel <armijn@tjaldur.nl>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Lee Jones <lee.jones@linaro.org>,
Marek Vasut <marek.vasut@gmail.com>,
Richard Weinberger <richard@nod.at>,
Thomas Gleixner <tglx@linutronix.de>,
Vignesh Raghavendra <vigneshr@ti.com>,
linux-mtd@lists.infradead.org
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Himanshu Jha <himanshujha199640@gmail.com>
Subject: [PATCH v2] mtd: st_spi_fsm: Use devm_platform_ioremap_resource() in stfsm_probe()
Date: Thu, 19 Sep 2019 12:04:30 +0000 [thread overview]
Message-ID: <eec0774d-135b-2b19-2595-7a126341c77c@web.de> (raw)
In-Reply-To: <20190919111014.6c569cf3@xps13>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Thu, 19 Sep 2019 13:30:51 +0200
Simplify this function implementation by using a known wrapper function.
* Thus reduce also a bit of exception handling code.
* Delete the local variable “res”.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
v2:
Further changes were requested by Miquel Raynal.
https://lore.kernel.org/r/20190919111014.6c569cf3@xps13/
* An error message was adjusted another bit.
* A variable was removed.
drivers/mtd/devices/st_spi_fsm.c | 13 ++-----------
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/mtd/devices/st_spi_fsm.c b/drivers/mtd/devices/st_spi_fsm.c
index f4d1667daaf9..ce18198301d5 100644
--- a/drivers/mtd/devices/st_spi_fsm.c
+++ b/drivers/mtd/devices/st_spi_fsm.c
@@ -2017,7 +2017,6 @@ static int stfsm_probe(struct platform_device *pdev)
{
struct device_node *np = pdev->dev.of_node;
struct flash_info *info;
- struct resource *res;
struct stfsm *fsm;
int ret;
@@ -2033,17 +2032,9 @@ static int stfsm_probe(struct platform_device *pdev)
fsm->dev = &pdev->dev;
platform_set_drvdata(pdev, fsm);
-
- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (!res) {
- dev_err(&pdev->dev, "Resource not found\n");
- return -ENODEV;
- }
-
- fsm->base = devm_ioremap_resource(&pdev->dev, res);
+ fsm->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(fsm->base)) {
- dev_err(&pdev->dev,
- "Failed to reserve memory region %pR\n", res);
+ dev_err(&pdev->dev, "Failed to reserve memory region\n");
return PTR_ERR(fsm->base);
}
--
2.23.0
prev parent reply other threads:[~2019-09-19 12:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 12:50 [PATCH] mtd: st_spi_fsm: Use devm_platform_ioremap_resource() in stfsm_probe() Markus Elfring
2019-09-19 9:10 ` Miquel Raynal
2019-09-19 10:50 ` Markus Elfring
2019-09-19 11:29 ` Greg Kroah-Hartman
2019-09-19 11:35 ` Miquel Raynal
2019-09-19 12:16 ` Markus Elfring
2019-09-19 12:04 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eec0774d-135b-2b19-2595-7a126341c77c@web.de \
--to=markus.elfring@web.de \
--cc=allison@lohutok.net \
--cc=armijn@tjaldur.nl \
--cc=bgolaszewski@baylibre.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=himanshujha199640@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=tglx@linutronix.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox