* [Kernel-janitors] [PATCH] usb/usbnet: replace schedule_timeout()
@ 2004-07-27 23:16 Nishanth Aravamudan
0 siblings, 0 replies; only message in thread
From: Nishanth Aravamudan @ 2004-07-27 23:16 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
I would appreciate any comments from the janitors list.
Applys-to: 2.6.7
Description: Use msleep() instead of schedule_timeout() to
guarantee the task delays for the desired time.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
--- linux-vanilla/drivers/usb/net/usbnet.c 2004-06-16 05:19:31.000000000 +0000
+++ linux-dev/drivers/usb/net/usbnet.c 2004-07-06 01:14:20.000000000 +0000
@@ -2550,8 +2550,7 @@ static int usbnet_stop (struct net_devic
while (skb_queue_len (&dev->rxq)
&& skb_queue_len (&dev->txq)
&& skb_queue_len (&dev->done)) {
- set_current_state (TASK_UNINTERRUPTIBLE);
- schedule_timeout (UNLINK_TIMEOUT_JIFFIES);
+ msleep(jiffies_to_msecs(UNLINK_TIMEOUT_JIFFIES);
devdbg (dev, "waited for %d urb completions", temp);
}
dev->wait = 0;
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-07-27 23:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-07-27 23:16 [Kernel-janitors] [PATCH] usb/usbnet: replace schedule_timeout() Nishanth Aravamudan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).