* [Kernel-janitors] [PATCH] TODO: add MODULE_VERSION
@ 2004-09-18 22:30 Scott Feldman
2004-09-21 13:54 ` maximilian attems
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Scott Feldman @ 2004-09-18 22:30 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 2054 bytes --]
[New to kj - is this the correct way to add to the TODO?]
* Add Matt Domsch's note to add MODULE_VERSION to all modules
to kj TODO list.
------------------------
--- TODO.orig 2004-09-18 15:23:20.813573216 -0700
+++ TODO 2004-09-18 15:26:28.069106048 -0700
@@ -636,4 +636,45 @@ altinstructions is a false positive, twe
The rest of the warnings look real, apart from the strange eh_frame.
+----------------------------------------------------------------------
+From: Matt Domsch
+Sat Jul 24 10:51:04 PDT 2004
+
+Request for Patches
+
+The 2.6.x kernel includes a MODULE_VERSION() parameter for providing
+one convenient way for all modules to state what *their* version is
+(as opposed to the version of the larger kernel they're included in).
+
+I've started submitting patches to the subsystem maintainers to add
+MODULE_VERSION() entries for drivers that I particularly care about,
+and would appreciate assistance handling the others.
+
+For modules which display their version as a string somewhere via
+printk, the preferred mechanism is:
+
+#define DRV_VERSION "1.0.0"
+MODULE_VERSION(DRV_VERSION);
+
+One aspect of MODULE_VERSION I haven't tackled is re-formatting
+existing versions into the preferred method as found in include/linux/module.h:
+
+/* Version of form [<epoch>:]<version>[-<extra-version>].
+ Or for CVS/RCS ID version, everything but the number is stripped.
+ <epoch>: A (small) unsigned integer which allows you to start
+ versions
+ anew. If not mentioned, it's zero. eg. "2:1.0" is after
+ "1:2.0".
+ <version>: The <version> may contain only alphanumerics and the
+ character `.'. Ordered by numeric sort for numeric parts,
+ ascii sort for ascii parts (as per RPM or DEB algorithm).
+ <extraversion>: Like <version>, but inserted for local
+ customizations, eg "rh3" or "rusty1".
+*/
+
+I leave such reformatting up to each driver author and/or patch
+submitter.
+
+Thanks,
+Matt
--------------------------------end-----------------------------------
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Kernel-janitors] [PATCH] TODO: add MODULE_VERSION
2004-09-18 22:30 [Kernel-janitors] [PATCH] TODO: add MODULE_VERSION Scott Feldman
@ 2004-09-21 13:54 ` maximilian attems
2004-09-22 8:48 ` Alexey Dobriyan
2004-09-22 18:31 ` maximilian attems
2 siblings, 0 replies; 4+ messages in thread
From: maximilian attems @ 2004-09-21 13:54 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 314 bytes --]
On Sat, 18 Sep 2004, Scott Feldman wrote:
> [New to kj - is this the correct way to add to the TODO?]
yup
> * Add Matt Domsch's note to add MODULE_VERSION to all modules
> to kj TODO list.
>
care to point me to patches that went upstream to linus?
didn't see one in bkbits for the last 3 weeks.
a++ maks
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Kernel-janitors] [PATCH] TODO: add MODULE_VERSION
2004-09-18 22:30 [Kernel-janitors] [PATCH] TODO: add MODULE_VERSION Scott Feldman
2004-09-21 13:54 ` maximilian attems
@ 2004-09-22 8:48 ` Alexey Dobriyan
2004-09-22 18:31 ` maximilian attems
2 siblings, 0 replies; 4+ messages in thread
From: Alexey Dobriyan @ 2004-09-22 8:48 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 394 bytes --]
On Tue, 21 Sep 2004 maximilian attems wrote:
>
> On Sat, 18 Sep 2004, Scott Feldman wrote:
>
> > * Add Matt Domsch's note to add MODULE_VERSION to all modules
> > to kj TODO list.
>
> care to point me to patches that went upstream to linus?
> didn't see one in bkbits for the last 3 weeks.
http://linux.bkbits.net:8080/linux-2.6/search/?expr=MODULE_VERSION&search=ChangeSet+comments
Alexey
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Kernel-janitors] [PATCH] TODO: add MODULE_VERSION
2004-09-18 22:30 [Kernel-janitors] [PATCH] TODO: add MODULE_VERSION Scott Feldman
2004-09-21 13:54 ` maximilian attems
2004-09-22 8:48 ` Alexey Dobriyan
@ 2004-09-22 18:31 ` maximilian attems
2 siblings, 0 replies; 4+ messages in thread
From: maximilian attems @ 2004-09-22 18:31 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 545 bytes --]
On Wed, 22 Sep 2004, Alexey Dobriyan wrote:
> On Tue, 21 Sep 2004 maximilian attems wrote:
> >
> > On Sat, 18 Sep 2004, Scott Feldman wrote:
> >
> > > * Add Matt Domsch's note to add MODULE_VERSION to all modules
> > > to kj TODO list.
> >
> > care to point me to patches that went upstream to linus?
> > didn't see one in bkbits for the last 3 weeks.
>
> http://linux.bkbits.net:8080/linux-2.6/search/?expr=MODULE_VERSION&search=ChangeSet+comments
>
thanks to you guys, added.
--
maks
kernel janitor http://janitor.kernelnewbies.org/
[-- Attachment #2: Type: text/plain, Size: 167 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-09-22 18:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-09-18 22:30 [Kernel-janitors] [PATCH] TODO: add MODULE_VERSION Scott Feldman
2004-09-21 13:54 ` maximilian attems
2004-09-22 8:48 ` Alexey Dobriyan
2004-09-22 18:31 ` maximilian attems
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).