kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [KJ] cleanup-drivers_usb_serial_cypress_m8.patch
@ 2005-06-29 16:49 Alexey Dobriyan
  2005-06-29 16:58 ` Greg KH
  0 siblings, 1 reply; 2+ messages in thread
From: Alexey Dobriyan @ 2005-06-29 16:49 UTC (permalink / raw)
  To: kernel-janitors

> Reading this driver I noticed some trailing whitespaces and tabs so I
> removed them with some 80th column fitting and a few more similar
> things.

> --- quilt.orig/drivers/usb/serial/cypress_m8.c
> +++ quilt/drivers/usb/serial/cypress_m8.c

> -			tty->termios->c_cflag = B4800 | CS8 | CREAD | HUPCL | CLOCAL;
> +			tty->termios->c_cflag = B4800 | CS8 | CREAD | HUPCL |
> +				CLOCAL;

Well, this should be changed to:

			tty->termios->c_cflag 					B4800 | CS8 | CREAD | HUPCL | CLOCAL;

> -			tty->termios->c_cflag = B9600 | CS8 | CREAD | HUPCL | CLOCAL;
> +			tty->termios->c_cflag = B9600 | CS8 | CREAD | HUPCL |
> +				CLOCAL;

> -			priv->diff_status |= priv->current_status ^ priv->prev_status;
> +			priv->diff_status |= priv->current_status ^
> +				priv->prev_status;

IMO, better
			priv->diff_status |				priv->current_status ^ priv->prev_status;
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [KJ] cleanup-drivers_usb_serial_cypress_m8.patch
  2005-06-29 16:49 [KJ] cleanup-drivers_usb_serial_cypress_m8.patch Alexey Dobriyan
@ 2005-06-29 16:58 ` Greg KH
  0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2005-06-29 16:58 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 823 bytes --]

On Wed, Jun 29, 2005 at 08:49:51PM +0400, Alexey Dobriyan wrote:
> > Reading this driver I noticed some trailing whitespaces and tabs so I
> > removed them with some 80th column fitting and a few more similar
> > things.
> 
> > --- quilt.orig/drivers/usb/serial/cypress_m8.c
> > +++ quilt/drivers/usb/serial/cypress_m8.c
> 
> > -			tty->termios->c_cflag = B4800 | CS8 | CREAD | HUPCL | CLOCAL;
> > +			tty->termios->c_cflag = B4800 | CS8 | CREAD | HUPCL |
> > +				CLOCAL;
> 
> Well, this should be changed to:
> 
> 			tty->termios->c_cflag =
> 					B4800 | CS8 | CREAD | HUPCL | CLOCAL;

Ick, no.  Why?  We don't inforce the 80 column rule that hard...

But if you really are worried about it try:

			tty->termios->c_cflag = B4800 | CS8 | CREAD | 
					        HUPCL | CLOCAL;

Which is more readable.

thanks,

greg k-h

[-- Attachment #2: Type: text/plain, Size: 167 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
http://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-06-29 16:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-06-29 16:49 [KJ] cleanup-drivers_usb_serial_cypress_m8.patch Alexey Dobriyan
2005-06-29 16:58 ` Greg KH

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).