kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [KJ] [PATCH] drivers/video/vgastate.c - remove unnecessary calls to
@ 2005-07-29 13:45 Jerome Steunenberg
  2005-07-29 17:38 ` [KJ] [PATCH] drivers/video/vgastate.c - remove unnecessary calls Tobias Klauser
  2005-08-03  9:47 ` [KJ] [PATCH] drivers/video/vgastate.c - remove unnecessary calls to Jerome Steunenberg
  0 siblings, 2 replies; 3+ messages in thread
From: Jerome Steunenberg @ 2005-07-29 13:45 UTC (permalink / raw)
  To: kernel-janitors

Second try for this patch. Please tell me if I got it OK!
For the line wrapping, it now passes patch-tester@coderock.org, so I hope it's OK.
If not, can those of you who use Thunderbird tell me what settings you use ? Thanks

In drivers/video/vgastate.c, the unnecessary calls to init_module and cleanup_module have been removed

Signed-off-by: Jerome Steunenberg <jerome@steunenberg.org>



--- linux-2.6.13-rc3/drivers/video/vgastate.c.orig	2005-07-25 15:09:51.000000000 +0200
+++ linux-2.6.13-rc3/drivers/video/vgastate.c	2005-07-29 15:03:45.000000000 +0200
@@ -490,11 +490,6 @@ int restore_vga (struct vgastate *state)
  	return 0;
  }

-#ifdef MODULE
-int init_module(void) { return 0; };
-void cleanup_module(void) {};
-#endif
-
  EXPORT_SYMBOL(save_vga);
  EXPORT_SYMBOL(restore_vga);

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [KJ] [PATCH] drivers/video/vgastate.c - remove unnecessary calls
  2005-07-29 13:45 [KJ] [PATCH] drivers/video/vgastate.c - remove unnecessary calls to Jerome Steunenberg
@ 2005-07-29 17:38 ` Tobias Klauser
  2005-08-03  9:47 ` [KJ] [PATCH] drivers/video/vgastate.c - remove unnecessary calls to Jerome Steunenberg
  1 sibling, 0 replies; 3+ messages in thread
From: Tobias Klauser @ 2005-07-29 17:38 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 881 bytes --]

On 2005-07-29 at 15:45:15 +0200, Jerome Steunenberg <jerome@steunenberg.org> wrote:
> Second try for this patch. Please tell me if I got it OK!
> For the line wrapping, it now passes patch-tester@coderock.org, so I hope 
> it's OK.
> If not, can those of you who use Thunderbird tell me what settings you use 
> ? Thanks
> 
> In drivers/video/vgastate.c, the unnecessary calls to init_module and 
> cleanup_module have been removed
> 
> Signed-off-by: Jerome Steunenberg <jerome@steunenberg.org>
> 
> 
> 
> --- linux-2.6.13-rc3/drivers/video/vgastate.c.orig	2005-07-25 
> 15:09:51.000000000 +0200
> +++ linux-2.6.13-rc3/drivers/video/vgastate.c	2005-07-29 
> 15:03:45.000000000 +0200

Unfortunately it still wraps lines.

I'm not using TB so I just do a shot in the dark; Try to attach your
patch + description as a _plain text_ attachement. This should also
work.

Cheers, Tobias

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [KJ] [PATCH] drivers/video/vgastate.c - remove unnecessary calls to
  2005-07-29 13:45 [KJ] [PATCH] drivers/video/vgastate.c - remove unnecessary calls to Jerome Steunenberg
  2005-07-29 17:38 ` [KJ] [PATCH] drivers/video/vgastate.c - remove unnecessary calls Tobias Klauser
@ 2005-08-03  9:47 ` Jerome Steunenberg
  1 sibling, 0 replies; 3+ messages in thread
From: Jerome Steunenberg @ 2005-08-03  9:47 UTC (permalink / raw)
  To: kernel-janitors

[-- Attachment #1: Type: text/plain, Size: 662 bytes --]

Third try for this patch. Now with KMail instead of Thunderbird. Please tell 
me if I got it OK!

In drivers/video/vgastate.c, the unnecessary calls to init_module and 
cleanup_module have been removed

Signed-off-by: Jerome Steunenberg <jerome@steunenberg.org>

--- linux-2.6.13-rc3/drivers/video/vgastate.c.orig	2005-07-25 15:09:51.000000000 +0200
+++ linux-2.6.13-rc3/drivers/video/vgastate.c	2005-07-29 15:03:45.000000000 +0200
@@ -490,11 +490,6 @@ int restore_vga (struct vgastate *state)
 	return 0;
 }
 
-#ifdef MODULE
-int init_module(void) { return 0; };
-void cleanup_module(void) {};
-#endif
-
 EXPORT_SYMBOL(save_vga);
 EXPORT_SYMBOL(restore_vga);
 

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-08-03  9:47 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-07-29 13:45 [KJ] [PATCH] drivers/video/vgastate.c - remove unnecessary calls to Jerome Steunenberg
2005-07-29 17:38 ` [KJ] [PATCH] drivers/video/vgastate.c - remove unnecessary calls Tobias Klauser
2005-08-03  9:47 ` [KJ] [PATCH] drivers/video/vgastate.c - remove unnecessary calls to Jerome Steunenberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).