* [PATCH] APIC: Remove unused variable
@ 2010-06-05 20:56 Richard Weinberger
2010-06-05 21:19 ` Dan Carpenter
0 siblings, 1 reply; 3+ messages in thread
From: Richard Weinberger @ 2010-06-05 20:56 UTC (permalink / raw)
To: tglx
Cc: mingo, hpa, x86, rakib.mullick, ebiederm, gorcunov, linux-kernel,
kernel-janitors, Richard Weinberger
base is never used in this file.
Signed-off-by: Richard Weinberger <richard@nod.at>
---
arch/x86/kernel/apic/es7000_32.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/apic/es7000_32.c b/arch/x86/kernel/apic/es7000_32.c
index 425e53a..ef34391 100644
--- a/arch/x86/kernel/apic/es7000_32.c
+++ b/arch/x86/kernel/apic/es7000_32.c
@@ -129,8 +129,6 @@ int es7000_plat;
* GSI override for ES7000 platforms.
*/
-static unsigned int base;
-
static int __cpuinit wakeup_secondary_cpu_via_mip(int cpu, unsigned long eip)
{
unsigned long vect = 0, psaival = 0;
--
1.6.6.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] APIC: Remove unused variable
2010-06-05 20:56 [PATCH] APIC: Remove unused variable Richard Weinberger
@ 2010-06-05 21:19 ` Dan Carpenter
2010-06-05 21:28 ` Richard Weinberger
0 siblings, 1 reply; 3+ messages in thread
From: Dan Carpenter @ 2010-06-05 21:19 UTC (permalink / raw)
To: Richard Weinberger
Cc: tglx, mingo, hpa, x86, rakib.mullick, ebiederm, gorcunov,
linux-kernel, kernel-janitors
On Sat, Jun 05, 2010 at 10:56:09PM +0200, Richard Weinberger wrote:
> base is never used in this file.
>
This is left over from commit 7b20bd5fb9 "x86, irq: Kill
io_apic_renumber_irq" where we removed the es7000_rename_gsi() function.
Could you remove the comment that went with it as well?
/*
* GSI override for ES7000 platforms.
*/
regards,
dan carpenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] APIC: Remove unused variable
2010-06-05 21:19 ` Dan Carpenter
@ 2010-06-05 21:28 ` Richard Weinberger
0 siblings, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2010-06-05 21:28 UTC (permalink / raw)
To: tglx
Cc: mingo, hpa, x86, rakib.mullick, ebiederm, gorcunov, linux-kernel,
kernel-janitors, Richard Weinberger
base is never used in this file.
---
arch/x86/kernel/apic/es7000_32.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/arch/x86/kernel/apic/es7000_32.c b/arch/x86/kernel/apic/es7000_32.c
index 425e53a..770262b 100644
--- a/arch/x86/kernel/apic/es7000_32.c
+++ b/arch/x86/kernel/apic/es7000_32.c
@@ -125,12 +125,6 @@ static unsigned long host_addr;
int es7000_plat;
-/*
- * GSI override for ES7000 platforms.
- */
-
-static unsigned int base;
-
static int __cpuinit wakeup_secondary_cpu_via_mip(int cpu, unsigned long eip)
{
unsigned long vect = 0, psaival = 0;
--
1.6.6.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-06-05 21:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-05 20:56 [PATCH] APIC: Remove unused variable Richard Weinberger
2010-06-05 21:19 ` Dan Carpenter
2010-06-05 21:28 ` Richard Weinberger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox