* [patch -next] megaraid: unlock on error path
@ 2010-10-14 18:21 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2010-10-14 18:21 UTC (permalink / raw)
To: Neela Syam Kolli, bo yang
Cc: James E.J. Bottomley, linux-scsi, linux-kernel, kernel-janitors
We need to release the semaphore here before returning.
This was introduced in 39a985547cb: "[SCSI] megaraid_sas: Add Online
Controller Reset to MegaRAID SAS drive"
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/scsi/megaraid/megaraid_sas.c b/drivers/scsi/megaraid/megaraid_sas.c
index 55951f4..ab28bae 100644
--- a/drivers/scsi/megaraid/megaraid_sas.c
+++ b/drivers/scsi/megaraid/megaraid_sas.c
@@ -4436,11 +4436,13 @@ static int megasas_mgmt_ioctl_fw(struct file *file, unsigned long arg)
printk(KERN_ERR "megaraid_sas: timed out while"
"waiting for HBA to recover\n");
error = -ENODEV;
- goto out_kfree_ioc;
+ goto out_up;
}
spin_unlock_irqrestore(&instance->hba_lock, flags);
error = megasas_mgmt_fw_ioctl(instance, user_ioc, ioc);
+
+ out_up:
up(&instance->ioctl_sem);
out_kfree_ioc:
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-10-14 18:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-14 18:21 [patch -next] megaraid: unlock on error path Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox