From: Greg KH <greg@kroah.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: Janitor-Question: use __set_bit instead of |=
Date: Tue, 31 May 2011 04:49:52 +0000 [thread overview]
Message-ID: <20110531044952.GB31219@kroah.com> (raw)
In-Reply-To: <201105302323.43979.PeterHuewe@gmx.de>
On Mon, May 30, 2011 at 11:23:40PM +0200, Peter Hüwe wrote:
> Hi Janitors, staging-list
>
> what is your opinion on using set_bit instead of using |= to set a bit?
> Is it worth the effort to convert existing |= to set_bit?
I doubt converting existing stuff is needed, but any future stuff is
always nice to use set_bit() for the reasons you suggest.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-05-31 4:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-30 21:23 Janitor-Question: use __set_bit instead of |= Peter Hüwe
2011-05-31 4:49 ` Greg KH [this message]
2011-05-31 7:11 ` walter harms
2011-05-31 9:05 ` Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110531044952.GB31219@kroah.com \
--to=greg@kroah.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox