* [patch] vmwgfx: return -EFAULT instead of number of bytes remaining
@ 2011-10-18 6:09 Dan Carpenter
2011-10-18 6:37 ` Thomas Hellstrom
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-10-18 6:09 UTC (permalink / raw)
To: David Airlie; +Cc: Dave Airlie, Thomas Hellstrom, kernel-janitors, dri-devel
The intent here was to return an error code, but instead the code
returns the number of bytes remaining (that weren't copied).
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
index 97f23ab..3f63435 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
@@ -150,6 +150,7 @@ int vmw_present_ioctl(struct drm_device *dev, void *data,
ret = copy_from_user(clips, clips_ptr, num_clips * sizeof(*clips));
if (ret) {
DRM_ERROR("Failed to copy clip rects from userspace.\n");
+ ret = -EFAULT;
goto out_no_copy;
}
@@ -241,6 +242,7 @@ int vmw_present_readback_ioctl(struct drm_device *dev, void *data,
ret = copy_from_user(clips, clips_ptr, num_clips * sizeof(*clips));
if (ret) {
DRM_ERROR("Failed to copy clip rects from userspace.\n");
+ ret = -EFAULT;
goto out_no_copy;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch] vmwgfx: return -EFAULT instead of number of bytes remaining
2011-10-18 6:09 [patch] vmwgfx: return -EFAULT instead of number of bytes remaining Dan Carpenter
@ 2011-10-18 6:37 ` Thomas Hellstrom
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Hellstrom @ 2011-10-18 6:37 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Dave Airlie, kernel-janitors, dri-devel
On 10/18/2011 08:09 AM, Dan Carpenter wrote:
> The intent here was to return an error code, but instead the code
> returns the number of bytes remaining (that weren't copied).
>
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
>
Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
> index 97f23ab..3f63435 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
> @@ -150,6 +150,7 @@ int vmw_present_ioctl(struct drm_device *dev, void *data,
> ret = copy_from_user(clips, clips_ptr, num_clips * sizeof(*clips));
> if (ret) {
> DRM_ERROR("Failed to copy clip rects from userspace.\n");
> + ret = -EFAULT;
> goto out_no_copy;
> }
>
> @@ -241,6 +242,7 @@ int vmw_present_readback_ioctl(struct drm_device *dev, void *data,
> ret = copy_from_user(clips, clips_ptr, num_clips * sizeof(*clips));
> if (ret) {
> DRM_ERROR("Failed to copy clip rects from userspace.\n");
> + ret = -EFAULT;
> goto out_no_copy;
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-18 6:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-18 6:09 [patch] vmwgfx: return -EFAULT instead of number of bytes remaining Dan Carpenter
2011-10-18 6:37 ` Thomas Hellstrom
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox