* [patch 1/2 -next] USB: gadget: midi: fix range check in
@ 2011-10-18 6:24 Dan Carpenter
2011-10-18 8:27 ` [patch 1/2 -next] USB: gadget: midi: fix range check in f_midi_out_open() Daniel Mack
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-10-18 6:24 UTC (permalink / raw)
To: kernel-janitors
! has higher precedence than >= and since neither 0 nor 1 are greater
than 8 the condition is always false.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/usb/gadget/f_midi.c b/drivers/usb/gadget/f_midi.c
index 44858dc..ef1bc7a 100644
--- a/drivers/usb/gadget/f_midi.c
+++ b/drivers/usb/gadget/f_midi.c
@@ -644,7 +644,7 @@ static int f_midi_out_open(struct snd_rawmidi_substream *substream)
{
struct f_midi *midi = substream->rmidi->private_data;
- if (!substream->number >= MAX_PORTS)
+ if (substream->number >= MAX_PORTS)
return -EINVAL;
VDBG(midi, "%s()\n", __func__);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [patch 1/2 -next] USB: gadget: midi: fix range check in f_midi_out_open()
2011-10-18 6:24 [patch 1/2 -next] USB: gadget: midi: fix range check in Dan Carpenter
@ 2011-10-18 8:27 ` Daniel Mack
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Mack @ 2011-10-18 8:27 UTC (permalink / raw)
To: kernel-janitors
On 18.10.11 08:24, Dan Carpenter wrote:
> ! has higher precedence than>= and since neither 0 nor 1 are greater
> than 8 the condition is always false.
Sure. The call in question actually not more than a sanity check, as
lower layers will never call this function with an invalid substream number.
Thanks for spotting this.
> Signed-off-by: Dan Carpenter<dan.carpenter@oracle.com>
Acked-by: Daniel Mack <zonque@gmail.com>
>
> diff --git a/drivers/usb/gadget/f_midi.c b/drivers/usb/gadget/f_midi.c
> index 44858dc..ef1bc7a 100644
> --- a/drivers/usb/gadget/f_midi.c
> +++ b/drivers/usb/gadget/f_midi.c
> @@ -644,7 +644,7 @@ static int f_midi_out_open(struct snd_rawmidi_substream *substream)
> {
> struct f_midi *midi = substream->rmidi->private_data;
>
> - if (!substream->number>= MAX_PORTS)
> + if (substream->number>= MAX_PORTS)
> return -EINVAL;
>
> VDBG(midi, "%s()\n", __func__);
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-18 8:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-18 6:24 [patch 1/2 -next] USB: gadget: midi: fix range check in Dan Carpenter
2011-10-18 8:27 ` [patch 1/2 -next] USB: gadget: midi: fix range check in f_midi_out_open() Daniel Mack
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox