* [patch] mmc: ushc: fix an endianness conversion in ushc_request()
@ 2011-11-20 21:06 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2011-11-20 21:06 UTC (permalink / raw)
To: Chris Ball; +Cc: Jesper Juhl, linux-mmc, kernel-janitors
The ->cmd_idx field is 8 bits, not 16 so the call to cpu_to_le16()
will probably set cmd_idx to zero here on big endian systems.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This is a static checker bug. Untested.
diff --git a/drivers/mmc/host/ushc.c b/drivers/mmc/host/ushc.c
index f08f944..8b7367a 100644
--- a/drivers/mmc/host/ushc.c
+++ b/drivers/mmc/host/ushc.c
@@ -278,7 +278,7 @@ static void ushc_request(struct mmc_host *mmc, struct mmc_request *req)
ushc->current_req = req;
/* Start cmd with CBW. */
- ushc->cbw->cmd_idx = cpu_to_le16(req->cmd->opcode);
+ ushc->cbw->cmd_idx = req->cmd->opcode;
if (req->data)
ushc->cbw->block_size = cpu_to_le16(req->data->blksz);
else
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-11-20 21:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-20 21:06 [patch] mmc: ushc: fix an endianness conversion in ushc_request() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox