* [patch] [media] tm6000: using an uninitialized variable in debug code
@ 2011-12-14 6:17 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2011-12-14 6:17 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: David Härdeman, Jarod Wilson, Thierry Reding, linux-media,
kernel-janitors
dprintk() dereferences "ir". I'm not sure why gcc doesn't complain
about this.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/video/tm6000/tm6000-input.c b/drivers/media/video/tm6000/tm6000-input.c
index 8d92527..7844607 100644
--- a/drivers/media/video/tm6000/tm6000-input.c
+++ b/drivers/media/video/tm6000/tm6000-input.c
@@ -408,13 +408,13 @@ int tm6000_ir_init(struct tm6000_core *dev)
if (!dev->ir_codes)
return 0;
- dprintk(2, "%s\n",__func__);
-
ir = kzalloc(sizeof(*ir), GFP_ATOMIC);
rc = rc_allocate_device();
if (!ir || !rc)
goto out;
+ dprintk(2, "%s\n", __func__);
+
/* record handles to ourself */
ir->dev = dev;
dev->ir = ir;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-12-14 6:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-14 6:17 [patch] [media] tm6000: using an uninitialized variable in debug code Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox