[patch] usb: gadget: add a sparse endian notation

[patch] usb: gadget: add a sparse endian notation

[Dan Carpenter]

The original code works fine, but Sparse complains because it isn't
annotated properly.

drivers/usb/gadget/composite.c:793:26: warning: incorrect type in assignment (different base types)
drivers/usb/gadget/composite.c:793:26:    expected unsigned short [unsigned] [usertype] language
devel/drivers/usb/gadget/composite.c:793:26:    got restricted __le16 [usertype] <noident>
devel/drivers/usb/gadget/composite.c:795:29: warning: restricted __le16 degrades to integer
drivers/usb/gadget/composite.c:798:24: warning: incorrect type in assignment (different base types)
drivers/usb/gadget/composite.c:798:24:    expected restricted __le16 [usertype] <noident>
devel/drivers/usb/gadget/composite.c:798:24:    got unsigned short [unsigned] [usertype] language

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
index baaebf2..4672651 100644
--- a/drivers/usb/gadget/composite.c
+++ b/drivers/usb/gadget/composite.c
@@ -785,7 +785,7 @@ done:
 static void collect_langs(struct usb_gadget_strings **sp, __le16 *buf)
 {
 	const struct usb_gadget_strings	*s;
-	u16				language;
+	__le16				language;
 	__le16				*tmp;
 
 	while (*sp) {

Re: [patch] usb: gadget: add a sparse endian notation

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 948 bytes --]

On Tue, Apr 17, 2012 at 09:30:22AM +0300, Dan Carpenter wrote:
> The original code works fine, but Sparse complains because it isn't
> annotated properly.
> 
> drivers/usb/gadget/composite.c:793:26: warning: incorrect type in assignment (different base types)
> drivers/usb/gadget/composite.c:793:26:    expected unsigned short [unsigned] [usertype] language
> devel/drivers/usb/gadget/composite.c:793:26:    got restricted __le16 [usertype] <noident>
> devel/drivers/usb/gadget/composite.c:795:29: warning: restricted __le16 degrades to integer
> drivers/usb/gadget/composite.c:798:24: warning: incorrect type in assignment (different base types)
> drivers/usb/gadget/composite.c:798:24:    expected restricted __le16 [usertype] <noident>
> devel/drivers/usb/gadget/composite.c:798:24:    got unsigned short [unsigned] [usertype] language
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

applied, thanks.

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]