* [patch 2/2] target: usb-gadget: cleanup duplicate initialization
@ 2012-04-17 6:32 Dan Carpenter
2012-04-18 7:12 ` Nicholas A. Bellinger
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-04-17 6:32 UTC (permalink / raw)
To: kernel-janitors
Sparse points out that we initialize .bAlternateSetting twice. But
fortunately USB_G_ALT_INT_BBB is zero so we initialize it to the same
value both times.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/target/usb-gadget/usb_gadget.c b/drivers/target/usb-gadget/usb_gadget.c
index ba62bef..78aa37e 100644
--- a/drivers/target/usb-gadget/usb_gadget.c
+++ b/drivers/target/usb-gadget/usb_gadget.c
@@ -1977,7 +1977,6 @@ static void usbg_deregister_configfs(void)
static struct usb_interface_descriptor bot_intf_desc = {
.bLength = sizeof(bot_intf_desc),
.bDescriptorType = USB_DT_INTERFACE,
- .bAlternateSetting = 0,
.bNumEndpoints = 2,
.bAlternateSetting = USB_G_ALT_INT_BBB,
.bInterfaceClass = USB_CLASS_MASS_STORAGE,
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch 2/2] target: usb-gadget: cleanup duplicate initialization
2012-04-17 6:32 [patch 2/2] target: usb-gadget: cleanup duplicate initialization Dan Carpenter
@ 2012-04-18 7:12 ` Nicholas A. Bellinger
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas A. Bellinger @ 2012-04-18 7:12 UTC (permalink / raw)
To: kernel-janitors
On Tue, 2012-04-17 at 09:32 +0300, Dan Carpenter wrote:
> Sparse points out that we initialize .bAlternateSetting twice. But
> fortunately USB_G_ALT_INT_BBB is zero so we initialize it to the same
> value both times.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/target/usb-gadget/usb_gadget.c b/drivers/target/usb-gadget/usb_gadget.c
> index ba62bef..78aa37e 100644
> --- a/drivers/target/usb-gadget/usb_gadget.c
> +++ b/drivers/target/usb-gadget/usb_gadget.c
> @@ -1977,7 +1977,6 @@ static void usbg_deregister_configfs(void)
> static struct usb_interface_descriptor bot_intf_desc = {
> .bLength = sizeof(bot_intf_desc),
> .bDescriptorType = USB_DT_INTERFACE,
> - .bAlternateSetting = 0,
> .bNumEndpoints = 2,
> .bAlternateSetting = USB_G_ALT_INT_BBB,
> .bInterfaceClass = USB_CLASS_MASS_STORAGE,
> --
Applied. Thanks DanC!
--nab
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-18 7:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-17 6:32 [patch 2/2] target: usb-gadget: cleanup duplicate initialization Dan Carpenter
2012-04-18 7:12 ` Nicholas A. Bellinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox