* [patch] sched/numa: checking for NULL instead of IS_ERR()
@ 2012-05-22 14:52 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2012-05-22 14:52 UTC (permalink / raw)
To: Peter Zijlstra; +Cc: Ingo Molnar, linux-kernel, kernel-janitors
If mpol_new() is called with MPOL_BIND then it can't return a NULL
pointer. We should be checking IS_ERR() here.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/kernel/sched/numa.c b/kernel/sched/numa.c
index 1149993..36d27ac 100644
--- a/kernel/sched/numa.c
+++ b/kernel/sched/numa.c
@@ -1481,9 +1481,9 @@ SYSCALL_DEFINE4(numa_mbind, unsigned long, addr, unsigned long, len,
mask = nodemask_of_node(ng->numa_entity.node);
mpol = mpol_new(MPOL_BIND, 0, &mask);
- if (!mpol) {
+ if (IS_ERR(mpol)) {
ng_put(ng);
- return -ENOMEM;
+ return PTR_ERR(mpol);
}
mpol->flags |= MPOL_MF_LAZY;
mpol->numa_group = ng;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-05-22 14:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-22 14:52 [patch] sched/numa: checking for NULL instead of IS_ERR() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox