* [patch] drm/udl: unlock before returning in udl_gem_mmap()
@ 2012-03-22 6:30 Dan Carpenter
2012-05-24 10:59 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-03-22 6:30 UTC (permalink / raw)
To: David Airlie; +Cc: Dave Airlie, kernel-janitors, dri-devel
If we hit an error here, then we should unlock and unreference obj
before returning.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c
index 852642d..6de6130 100644
--- a/drivers/gpu/drm/udl/udl_gem.c
+++ b/drivers/gpu/drm/udl/udl_gem.c
@@ -210,7 +210,7 @@ int udl_gem_mmap(struct drm_file *file, struct drm_device *dev,
ret = udl_gem_get_pages(gobj, GFP_KERNEL);
if (ret)
- return ret;
+ goto out;
if (!gobj->base.map_list.map) {
ret = drm_gem_create_mmap_offset(obj);
if (ret)
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] drm/udl: unlock before returning in udl_gem_mmap()
2012-03-22 6:30 [patch] drm/udl: unlock before returning in udl_gem_mmap() Dan Carpenter
@ 2012-05-24 10:59 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2012-05-24 10:59 UTC (permalink / raw)
To: David Airlie; +Cc: Dave Airlie, kernel-janitors, dri-devel
On Thu, Mar 22, 2012 at 09:30:56AM +0300, Dan Carpenter wrote:
> If we hit an error here, then we should unlock and unreference obj
> before returning.
>
This is still present in linux-next.
regards,
dan carpenter
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/udl/udl_gem.c b/drivers/gpu/drm/udl/udl_gem.c
> index 852642d..6de6130 100644
> --- a/drivers/gpu/drm/udl/udl_gem.c
> +++ b/drivers/gpu/drm/udl/udl_gem.c
> @@ -210,7 +210,7 @@ int udl_gem_mmap(struct drm_file *file, struct drm_device *dev,
>
> ret = udl_gem_get_pages(gobj, GFP_KERNEL);
> if (ret)
> - return ret;
> + goto out;
> if (!gobj->base.map_list.map) {
> ret = drm_gem_create_mmap_offset(obj);
> if (ret)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-24 10:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-22 6:30 [patch] drm/udl: unlock before returning in udl_gem_mmap() Dan Carpenter
2012-05-24 10:59 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox