* [patch] watchdog: sch56xx-common: set correct bits in register()
@ 2012-05-24 15:58 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2012-05-24 15:58 UTC (permalink / raw)
To: kernel-janitors
WDOG_NO_WAY_OUT (3) and WDOG_ACTIVE (0) are the bit numbers, not a mask.
So "data->wddev.status |= WDOG_ACTIVE;" was intended to set bit zero but
it is a no-op.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/hwmon/sch56xx-common.c b/drivers/hwmon/sch56xx-common.c
index 839087c..4380f5d 100644
--- a/drivers/hwmon/sch56xx-common.c
+++ b/drivers/hwmon/sch56xx-common.c
@@ -464,9 +464,9 @@ struct sch56xx_watchdog_data *sch56xx_watchdog_register(struct device *parent,
data->wddev.min_timeout = 1;
data->wddev.max_timeout = 255 * 60;
if (nowayout)
- data->wddev.status |= WDOG_NO_WAY_OUT;
+ set_bit(WDOG_NO_WAY_OUT, &data->wddev.status);
if (output_enable & SCH56XX_WDOG_OUTPUT_ENABLE)
- data->wddev.status |= WDOG_ACTIVE;
+ set_bit(WDOG_ACTIVE, &data->wddev.status);
/* Since the watchdog uses a downcounter there is no register to read
the BIOS set timeout from (if any was set at all) ->
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-05-24 15:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-24 15:58 [patch] watchdog: sch56xx-common: set correct bits in register() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox