public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: wfg@linux.intel.com
To: kernel-janitors@vger.kernel.org
Subject: [usb:usb-next 100/101] drivers/usb/chipidea/ci13xxx_pci.c:26:30: sparse: symbol 'pci_platdata' was n
Date: Sat, 07 Jul 2012 17:21:37 +0000	[thread overview]
Message-ID: <20120707172137.GA25074@localhost> (raw)

[-- Attachment #1: Type: text/plain, Size: 898 bytes --]

Hi Richard,

There are new sparse warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-next
head:   336c5c310e8f0d5baba7973765339eaf5d989fe1
commit: 77c4400f2f0fd8384ab5cbe41d81ccc664896b2d [100/101] USB: Chipidea: rename struct ci13xxx_udc_driver to struct ci13xxx_platform_data

All sparse warnings:

+ drivers/usb/chipidea/ci13xxx_pci.c:26:30: sparse: symbol 'pci_platdata' was not declared. Should it be static?
+ drivers/usb/chipidea/ci13xxx_pci.c:31:30: sparse: symbol 'langwell_pci_platdata' was not declared. Should it be static?
+ drivers/usb/chipidea/ci13xxx_pci.c:36:30: sparse: symbol 'penwell_pci_platdata' was not declared. Should it be static?

Please consider folding the attached diff :-)

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com>                     Intel Corporation

[-- Attachment #2: make-it-static-77c4400.diff --]
[-- Type: text/x-diff, Size: 915 bytes --]

diff --git a/drivers/usb/chipidea/ci13xxx_pci.c b/drivers/usb/chipidea/ci13xxx_pci.c
index cdcac3a..5ce8698 100644
--- a/drivers/usb/chipidea/ci13xxx_pci.c
+++ b/drivers/usb/chipidea/ci13xxx_pci.c
@@ -23,17 +23,17 @@
 /******************************************************************************
  * PCI block
  *****************************************************************************/
-struct ci13xxx_platform_data pci_platdata = {
+static struct ci13xxx_platform_data pci_platdata = {
 	.name		= UDC_DRIVER_NAME,
 	.capoffset	= DEF_CAPOFFSET,
 };
 
-struct ci13xxx_platform_data langwell_pci_platdata = {
+static struct ci13xxx_platform_data langwell_pci_platdata = {
 	.name		= UDC_DRIVER_NAME,
 	.capoffset	= 0,
 };
 
-struct ci13xxx_platform_data penwell_pci_platdata = {
+static struct ci13xxx_platform_data penwell_pci_platdata = {
 	.name		= UDC_DRIVER_NAME,
 	.capoffset	= 0,
 	.power_budget	= 200,

             reply	other threads:[~2012-07-07 17:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-07 17:21 wfg [this message]
2012-07-09  7:09 ` [usb:usb-next 100/101] drivers/usb/chipidea/ci13xxx_pci.c:26:30: sparse: symbol 'pci_platdata' w Richard Zhao
2012-07-09  7:16 ` Fengguang Wu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120707172137.GA25074@localhost \
    --to=wfg@linux.intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox