* [media] tvp5150: signedness bug in tvp5150_selmux()
@ 2012-07-12 14:47 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2012-07-12 14:47 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Javier Martin, Hans Verkuil, Tomasz Stanislawski, Paul Gortmaker,
linux-media, kernel-janitors
tvp5150_read() returns negative error codes so this needs to be an int
for the error handling to work.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/media/video/tvp5150.c b/drivers/media/video/tvp5150.c
index 0d897cb..a751b6c 100644
--- a/drivers/media/video/tvp5150.c
+++ b/drivers/media/video/tvp5150.c
@@ -257,7 +257,7 @@ static inline void tvp5150_selmux(struct v4l2_subdev *sd)
int opmode = 0;
struct tvp5150 *decoder = to_tvp5150(sd);
int input = 0;
- unsigned char val;
+ int val;
if ((decoder->output & TVP5150_BLACK_SCREEN) || !decoder->enable)
input = 8;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2012-07-12 14:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-12 14:47 [media] tvp5150: signedness bug in tvp5150_selmux() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox