public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
* [wireless:master 39/40] drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:2987
@ 2012-09-11  9:15 Fengguang Wu
  2012-09-11  9:48 ` Dan Carpenter
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Fengguang Wu @ 2012-09-11  9:15 UTC (permalink / raw)
  To: kernel-janitors

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless.git master
head:   4abd044af91057f7ea661a0f10c00a9673beef6b
commit: 74673db99ca3c09d34ea479f684522ceedb65eb9 [39/40] ath9k: make PA linearization optional, disabled by default and fix checks

All smatch warnings:

+ drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:2987 ath9k_hw_ar9300_get_eeprom() warn: if();
+ drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:2989 ath9k_hw_ar9300_get_eeprom() info: ignoring unreachable code.
+ drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:2989 ath9k_hw_ar9300_get_eeprom() info: ignoring unreachable code.
  drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:3372 ath9k_hw_ar9300_fill_eeprom() Error invalid range 4096 to -1

vim +2987 drivers/net/wireless/ath/ath9k/ar9003_eeprom.c

  2984		case EEP_PAPRD:
  2985			if (AR_SREV_9462(ah))
  2986				return false;
> 2987			if (!ah->config.enable_paprd);
  2988				return false;
  2989			return !!(pBase->featureEnable & BIT(5));

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com>                     Intel Corporation

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [wireless:master 39/40] drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:2987
  2012-09-11  9:15 [wireless:master 39/40] drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:2987 Fengguang Wu
@ 2012-09-11  9:48 ` Dan Carpenter
  2012-09-11  9:54 ` Fengguang Wu
  2012-09-11 10:00 ` Dan Carpenter
  2 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2012-09-11  9:48 UTC (permalink / raw)
  To: kernel-janitors

On Tue, Sep 11, 2012 at 05:15:37PM +0800, Fengguang Wu wrote:
>   drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:3372 ath9k_hw_ar9300_fill_eeprom() Error invalid range 4096 to -1

Sorry for this false positive.  I had it fixed in my tree but didn't
push.  It's pushed now.

regards,
dan carpenter

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [wireless:master 39/40] drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:2987
  2012-09-11  9:15 [wireless:master 39/40] drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:2987 Fengguang Wu
  2012-09-11  9:48 ` Dan Carpenter
@ 2012-09-11  9:54 ` Fengguang Wu
  2012-09-11 10:00 ` Dan Carpenter
  2 siblings, 0 replies; 4+ messages in thread
From: Fengguang Wu @ 2012-09-11  9:54 UTC (permalink / raw)
  To: kernel-janitors

On Tue, Sep 11, 2012 at 12:48:25PM +0300, Dan Carpenter wrote:
> On Tue, Sep 11, 2012 at 05:15:37PM +0800, Fengguang Wu wrote:
> >   drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:3372 ath9k_hw_ar9300_fill_eeprom() Error invalid range 4096 to -1
> 
> Sorry for this false positive.  I had it fixed in my tree but didn't
> push.  It's pushed now.

Great! I do see many "invalid range 4096 to -1" warnings.

Thanks,
Fengguang

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [wireless:master 39/40] drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:2987
  2012-09-11  9:15 [wireless:master 39/40] drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:2987 Fengguang Wu
  2012-09-11  9:48 ` Dan Carpenter
  2012-09-11  9:54 ` Fengguang Wu
@ 2012-09-11 10:00 ` Dan Carpenter
  2 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2012-09-11 10:00 UTC (permalink / raw)
  To: kernel-janitors

On Tue, Sep 11, 2012 at 05:54:55PM +0800, Fengguang Wu wrote:
> On Tue, Sep 11, 2012 at 12:48:25PM +0300, Dan Carpenter wrote:
> > On Tue, Sep 11, 2012 at 05:15:37PM +0800, Fengguang Wu wrote:
> > >   drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:3372 ath9k_hw_ar9300_fill_eeprom() Error invalid range 4096 to -1
> > 
> > Sorry for this false positive.  I had it fixed in my tree but didn't
> > push.  It's pushed now.
> 
> Great! I do see many "invalid range 4096 to -1" warnings.
> 

Could you send me a complete list of the warnings you have?  I could
look over them.

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-09-11 10:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-11  9:15 [wireless:master 39/40] drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:2987 Fengguang Wu
2012-09-11  9:48 ` Dan Carpenter
2012-09-11  9:54 ` Fengguang Wu
2012-09-11 10:00 ` Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox