ptmx_open() error: double unlock 'mutex:&devpts_mutex'

ptmx_open() error: double unlock 'mutex:&devpts_mutex'

[Fengguang Wu]

Hi Alan,

FYI, there are new smatch warnings show up in commit 89c8d91e31f267703e365593f6bfebb9f6d2ad01

drivers/tty/pty.c:670 ptmx_open() error: double unlock 'mutex:&devpts_mutex'

vim +670 drivers/tty/pty.c

   666	out:
   667		mutex_unlock(&tty_mutex);
   668		devpts_kill_index(inode, index);
   669	err_file:
 > 670	        mutex_unlock(&devpts_mutex);
   671		tty_free_file(filp);
   672		return retval;
   673	}
   674	

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu <wfg@linux.intel.com>                     Intel Corporation

Re: ptmx_open() error: double unlock 'mutex:&devpts_mutex'

[Alan Cox]

Thanks - patch in test.

Re: ptmx_open() error: double unlock 'mutex:&devpts_mutex'

[Dan Carpenter]

I sent a patch for this on "Wed, 11 Jul 2012 09:40:40 +0300" but I
don't know what happened to it.  The @linux.intel.com has been
rejecting emails from @oracle.com for the past few months but I
thought it was working in July.

----- The following addresses had permanent fatal errors -----
   <alan@linux.intel.com>

----- Transcript of session follows -----
403 4.7.0 encryption too weak 0 less than 128
<alan@linux.intel.com>... Deferred
... while talking to mtab.intel.com.:
>>> DATA
<<< 503 #5.5.1 RCPT first
Message could not be delivered for 3 days
Message will be deleted from queue

regards,
dan carpenter

Re: ptmx_open() error: double unlock 'mutex:&devpts_mutex'

[Alan Cox]

On Wed, 12 Sep 2012 18:50:54 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> I sent a patch for this on "Wed, 11 Jul 2012 09:40:40 +0300" but I
> don't know what happened to it.  The @linux.intel.com has been
> rejecting emails from @oracle.com for the past few months but I
> thought it was working in July.

If it's important cc my lxorguk account.

Alan