public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [patch] USB: chipidea: fix & vs | bug
Date: Fri, 14 Sep 2012 06:50:56 +0000	[thread overview]
Message-ID: <20120914065056.GA11886@elgon.mountain> (raw)

There is a '&' vs '|' typo in the original code so the condition is
never true and we don't queue the work.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---

diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
index 2f45bba..5294f81 100644
--- a/drivers/usb/chipidea/udc.c
+++ b/drivers/usb/chipidea/udc.c
@@ -1680,7 +1680,7 @@ static irqreturn_t udc_irq(struct ci13xxx *ci)
 	intr = hw_read(ci, OP_OTGSC, ~0);
 	hw_write(ci, OP_OTGSC, ~0, intr);
 
-	if (intr & (OTGSC_AVVIE & OTGSC_AVVIS))
+	if (intr & (OTGSC_AVVIE | OTGSC_AVVIS))
 		queue_work(ci->wq, &ci->vbus_work);
 
 	spin_unlock(&ci->lock);

             reply	other threads:[~2012-09-14  6:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-14  6:50 Dan Carpenter [this message]
2012-09-14  6:58 ` [patch] USB: chipidea: fix & vs | bug Richard Zhao
2013-02-15 10:26 ` Dan Carpenter
2013-02-15 11:08 ` Dan Carpenter
2013-02-15 12:54 ` Alexander Shishkin
2013-02-15 13:18 ` Dan Carpenter
2013-02-15 13:37 ` Alexander Shishkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120914065056.GA11886@elgon.mountain \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox