From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] USB: chipidea: fix & vs | bug
Date: Fri, 15 Feb 2013 12:54:56 +0000 [thread overview]
Message-ID: <87haldag9r.fsf@ashishki-desk.ger.corp.intel.com> (raw)
In-Reply-To: <20120914065056.GA11886@elgon.mountain>
Dan Carpenter <dan.carpenter@oracle.com> writes:
> On Fri, Feb 15, 2013 at 01:26:29PM +0300, Dan Carpenter wrote:
>> On Fri, Sep 14, 2012 at 02:58:20PM +0800, Richard Zhao wrote:
>> > On Fri, Sep 14, 2012 at 09:50:56AM +0300, Dan Carpenter wrote:
>> > > There is a '&' vs '|' typo in the original code so the condition is
>> > > never true and we don't queue the work.
>> > >
>> > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>> > > ---
>> > >
>> > > diff --git a/drivers/usb/chipidea/udc.c b/drivers/usb/chipidea/udc.c
>> > > index 2f45bba..5294f81 100644
>> > > --- a/drivers/usb/chipidea/udc.c
>> > > +++ b/drivers/usb/chipidea/udc.c
>> > > @@ -1680,7 +1680,7 @@ static irqreturn_t udc_irq(struct ci13xxx *ci)
>> > > intr = hw_read(ci, OP_OTGSC, ~0);
>> > > hw_write(ci, OP_OTGSC, ~0, intr);
>> > >
>> > > - if (intr & (OTGSC_AVVIE & OTGSC_AVVIS))
>> > > + if (intr & (OTGSC_AVVIE | OTGSC_AVVIS))
>> > It's not what I meant. Should be
>> > if ((intr & OTGSC_AVVIE) && (intr & OTGSC_AVVIS))
>> > I'm still testing it.
>>
>> How did the testing go?
>>
>
> Richard's email is bouncing. Probably I should just send this
> myself.
We're reverting this commit for 3.10 as part of Peter's vbus detection
patchset. If it seems more urgent, I guess we can revert it earlier as a
bugfix. Otherwise, I'd just leave it till 3.10.
Regards,
--
Alex
next prev parent reply other threads:[~2013-02-15 12:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 6:50 [patch] USB: chipidea: fix & vs | bug Dan Carpenter
2012-09-14 6:58 ` Richard Zhao
2013-02-15 10:26 ` Dan Carpenter
2013-02-15 11:08 ` Dan Carpenter
2013-02-15 12:54 ` Alexander Shishkin [this message]
2013-02-15 13:18 ` Dan Carpenter
2013-02-15 13:37 ` Alexander Shishkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87haldag9r.fsf@ashishki-desk.ger.corp.intel.com \
--to=alexander.shishkin@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox